Merge pull request #148 from astroDimitrios/feature/tab-admonition

Add support for tabs / tabset panels
carpentries · Apr 5, 2024 · e75e0a4 · e75e0a4
2 parents e9ca729 + a3bc6c8
commit e75e0a4
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 7 deletions.
diff --git a/R/validate_divs.R b/R/validate_divs.R
@@ -34,6 +34,8 @@
 #'  - discussion
 #'  - checklist
 #'  - testimonial
+#'  - tab (can only contain text, images, and code blocks)
+#'  - group-tab (can only contain text, images, and code blocks)
 #'
 #' Any other div names will produce structure in the resulting DOM, but they
 #' will not have any special visual styling.
@@ -75,7 +77,9 @@ KNOWN_DIVS <- c(
   "testimonial",
   "keypoints",
   "instructor",
-  "spoiler"
+  "spoiler",
+  "tab",
+  "group-tab"
 )
 
 #' @rdname validate_divs

diff --git a/man/validate_divs.Rd b/man/validate_divs.Rd
diff --git a/tests/testthat/_snaps/validation.md b/tests/testthat/_snaps/validation.md
@@ -58,7 +58,7 @@
     Message
       ! There were errors in 1/5 fenced divs
       
-      - The Carpentries Workbench knows the following div types callout, objectives, questions, challenge, prereq, checklist, solution, hint, discussion, testimonial, keypoints, instructor, spoiler
+      - The Carpentries Workbench knows the following div types callout, objectives, questions, challenge, prereq, checklist, solution, hint, discussion, testimonial, keypoints, instructor, spoiler, tab, group-tab
       
       validation-divs.md:26  [unknown div] unknown
 
@@ -494,7 +494,7 @@
       dv$validate_divs()
     Message
       ! There were errors in 1/5 fenced divs
-      ( ) The Carpentries Workbench knows the following div types callout, objectives, questions, challenge, prereq, checklist, solution, hint, discussion, testimonial, keypoints, instructor, spoiler
+      ( ) The Carpentries Workbench knows the following div types callout, objectives, questions, challenge, prereq, checklist, solution, hint, discussion, testimonial, keypoints, instructor, spoiler, tab, group-tab
       
       validation-divs.md:26 [unknown div] unknown
 
@@ -504,7 +504,7 @@
       dv$validate_divs()
     Message
       [33m![39m There were errors in 1/5 fenced divs
-      ( ) The Carpentries Workbench knows the following div types callout, objectives, questions, challenge, prereq, checklist, solution, hint, discussion, testimonial, keypoints, instructor, spoiler
+      ( ) The Carpentries Workbench knows the following div types callout, objectives, questions, challenge, prereq, checklist, solution, hint, discussion, testimonial, keypoints, instructor, spoiler, tab, group-tab
       
       validation-divs.md:26 [unknown div] unknown
 
@@ -514,7 +514,7 @@
       dv$validate_divs()
     Message
       ! There were errors in 1/5 fenced divs
-      ◌ The Carpentries Workbench knows the following div types callout, objectives, questions, challenge, prereq, checklist, solution, hint, discussion, testimonial, keypoints, instructor, spoiler
+      ◌ The Carpentries Workbench knows the following div types callout, objectives, questions, challenge, prereq, checklist, solution, hint, discussion, testimonial, keypoints, instructor, spoiler, tab, group-tab
       
       validation-divs.md:26 [unknown div] unknown
 
@@ -524,7 +524,7 @@
       dv$validate_divs()
     Message
       [33m![39m There were errors in 1/5 fenced divs
-      ◌ The Carpentries Workbench knows the following div types callout, objectives, questions, challenge, prereq, checklist, solution, hint, discussion, testimonial, keypoints, instructor, spoiler
+      ◌ The Carpentries Workbench knows the following div types callout, objectives, questions, challenge, prereq, checklist, solution, hint, discussion, testimonial, keypoints, instructor, spoiler, tab, group-tab
       
       validation-divs.md:26 [unknown div] unknown
 
@@ -639,7 +639,7 @@
       dv$validate_divs()
     Message
       ! There were errors in 1/5 fenced divs
-      ( ) The Carpentries Workbench knows the following div types callout, objectives, questions, challenge, prereq, checklist, solution, hint, discussion, testimonial, keypoints, instructor, spoiler
+      ( ) The Carpentries Workbench knows the following div types callout, objectives, questions, challenge, prereq, checklist, solution, hint, discussion, testimonial, keypoints, instructor, spoiler, tab, group-tab
       
       ::warning file=validation-divs.md,line=26:: [unknown div] unknown