Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow 404 nesting; clean up sidebar code #514

Merged
merged 10 commits into from
Sep 19, 2023
Merged

Conversation

zkamvar
Copy link
Contributor

@zkamvar zkamvar commented Sep 19, 2023

This will fix #498 by no longer relying on regular expressions to edit and modify the 404 HTML content.

This also does the following

  • removes the needless recursion from update_sidebar()
  • updates the documentation for sidebar functions and collects them into sidebar and sidebar_item.
  • updates the documentation for build_html

@zkamvar
Copy link
Contributor Author

zkamvar commented Sep 19, 2023

I have tested this with the integration test suite and can confirm that it works: https://htmlpreview.github.io/?https://github.com/carpentries/workbench-integration-test/blob/5c6bd9262c0bebaf3d189a6b7cda39c3ec7eb1ac/404.html

As a bonus, it allowed me to find a bug that I was not testing for 😬

@zkamvar zkamvar enabled auto-merge September 19, 2023 18:15
@zkamvar zkamvar merged commit 7942e44 into main Sep 19, 2023
@zkamvar zkamvar deleted the allow-404-nesting-fix-498 branch September 19, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

404 page setup link in menu does not work for nested errors
1 participant