Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix website preview #627

Merged
merged 3 commits into from
Dec 4, 2024
Merged

Fix website preview #627

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
22291fd
Fix website preview
Bisaloo Dec 2, 2024
21e122b
Increment version number to 0.16.10.9000
Bisaloo Dec 2, 2024
c8e0adb
Add NEWS bullet
Bisaloo Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: sandpaper
Title: Create and Curate Carpentries Lessons
Version: 0.16.10
Version: 0.16.10.9000
Authors@R: c(
person(given = "Robert",
family = "Davey",
Expand Down
8 changes: 8 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,11 @@
# sandpaper (development version)

## BUG FIXES

* The website preview feature which automatically opens a web browser after
running `build_lesson()` has been fixed to work with the latest version of
pkgdown (@Bisaloo, #627)

# sandpaper 0.16.10 (2024-11-11)

## NEW FEATURES
Expand Down
2 changes: 1 addition & 1 deletion R/build_site.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ build_site <- function(path = ".", quiet = !interactive(), preview = TRUE, overr
# At the end, a sitemap is created with our aggregated pages.
build_sitemap(pkg$dst_path, paths = html_pages$paths, quiet = quiet)

pkgdown::preview_site(pkg, "/", preview = preview)
pkgdown::preview_site(pkg, preview = preview)

if (!quiet) {
dst <- fs::path_rel(path = pkg$dst_path, start = path)
Expand Down
Loading