Update Dockerfile to focal and reorder steps #1158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achantavy
changed the title
|
It looks reasonable to me. @ryan-lane knows more a lot more about docker than me though - what do you think? |
| RUN pip install -e . && \ | ||
| pip install -r test-requirements.txt | ||
|
|
||
| # Install cartography | ||
| COPY . /srv/cartography |
There was a problem hiding this comment.
Thanks for taking care to upgrade. Can you explain what this line is for?
There was a problem hiding this comment.
Before :
copying source code was done before installing dependencies, so any change will trigger dependencies install
After :
first only requirements are copied, so the docker layer is cached
then files are copied, so change in files wont trigger a new dependencies install
achantavy
approved these changes
Sep 26, 2023
chandanchowdhury
pushed a commit
to juju4/cartography
that referenced
this pull request
Jun 26, 2024
This PR includes : - upgrade from bionic to focal (bionic is EOL this month) - reorder some step to allow layer cach for pip dependencies Focal use python3.8, so everything should be OK. Reordering steps allow pip dependencies install before all source code is copied (this is quite anoying for local tests ...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes :
Focal use python3.8, so everything should be OK.
Reordering steps allow pip dependencies install before all source code is copied (this is quite anoying for local tests ...)