Update build process, adapt wasm and keychain CI #717
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
steebchen
force-pushed
the
chore/build
branch
from
381f62c to
86f1b2c
Compare
steebchen
force-pushed
the
chore/build
branch
from
86f1b2c to
d9cfbe7
Compare
| branches: [main] | ||
| jobs: | ||
| test: | ||
| if: always() == 'skip' # temporarily skip cc @jun |
This comment was marked as outdated.
This comment was marked as outdated.
turbo.json
Outdated
| "build-wasm": { | ||
| "outputs": ["packages/account-wasm/pkg/**"] | ||
| }, |
There was a problem hiding this comment.
It's prob simpler to rename the script to build:deps in packages/account-wasm/package.json so pnpm turbo build:deps handles the all lib build
There was a problem hiding this comment.
we probably don't want to build wasm everywhere though as it has more deps and requires more resources
There was a problem hiding this comment.
ah I see, I guess that's why pkg is committed. Makes sense
.tool-versions
Outdated
| @@ -1,3 +1,4 @@ | |||
| scarb 2.7.0 | |||
| starknet-foundry 0.18.0 | |||
| nodejs v20.11.1 | |||
| pnpm 9.7.0 | |||
There was a problem hiding this comment.
pnpm version should be managed by corepack
# once Node.js is installed via asdf or whatever vm,
corepack enable pnpmThere was a problem hiding this comment.
can we have it here anyway? I am using asdf for pnpm
There was a problem hiding this comment.
I prefer to avoid duplication of versioning
Line 3 in 1bc2065
No description provided.