Update flaky test in 0.44.x

.github/workflows/release-process.yml

@@ -23,6 +23,7 @@ jobs:
         uses: carvel-dev/setup-action@v1
         with:
           only: imgpkg
+          token: ${{ secrets.GITHUB_TOKEN }}
 
       - name: Login to GitHub Container Registry
         uses: docker/login-action@v2

.github/workflows/release-published.yml

@@ -11,6 +11,7 @@ jobs:
         with:
           only: kctrl
           kctrl: ${{ github.event.release.tag_name }}
+          token: ${{ secrets.GITHUB_TOKEN }}
       - run: |
           kctrl version
           version=`kctrl version`

.github/workflows/test-kctrl-gh.yml

@@ -29,6 +29,7 @@ jobs:
       uses: carvel-dev/setup-action@v1
       with:
         only: ytt, kbld, imgpkg, vendir, kapp
+        token: ${{ secrets.GITHUB_TOKEN }}
     - name: Run Tests
       run: |
         set -e -x

hack/dependencies_test.go

@@ -14,11 +14,13 @@ import (
 )
 
 func init() {
-	client = http.DefaultClient
+	client = &http.Client{
+		// try to use a Github API token from the environment to avoid rate-limiting
+		Transport: newGithubTransport(),
+	}
 }
 
 func TestDependencyDownload(t *testing.T) {
-	client = http.DefaultClient
 	for _, tc := range []struct {
 		name string
 		dep  dependency

test/e2e/assets/https-server/server.yml

@@ -9,8 +9,6 @@ kind: Service
 metadata:
   namespace: https-server
   name: https-svc
-  annotations:
-    kapp.k14s.io/change-group: server
 spec:
   selector:
     app: self-signed-https-server
@@ -23,8 +21,6 @@ kind: Deployment
 metadata:
   name: self-signed-https-server
   namespace: https-server
-  annotations:
-    kapp.k14s.io/change-group: server
 spec:
   replicas: 1
   selector:
@@ -131,30 +127,3 @@ binaryData:
   #         deploy:
   #         - kapp: {}
   packages.tar: "H4sIAHczxmIAA+2SS2rEMAyGZ51T6AL22KmTQg5RuupetZVJyGOM4wRC6d0bx5M+oAylDJRCvo0sS/+PjGVRN3ii4Wjjgc9de7gxQohcKQjxPs/WKNKYr2QiA6nSXKo7makUhFSZzA4gbj3Id4yDR7eMYprrfUtbWV6px6fAe/wnMMYStPUTuaE+9wUY9MjjLtT9iWt0E7Xc0HScJLa2Qpk0dW8KeIz7knTkMYiKBKDHjgq4bBJ7pmrpZBqZJuc/WXHJBRfJYEkHlaPy4WfCpXnaBo0eAJ4626Kn4ASweQZK8rraEgaV93bLAqNrCxj7cSBzuf1qFTSz9wW8vF5yQ7Y9zx/VBq1dy3/9iTs7Ozu/4A1GdDfIAAgAAA=="
-
-# TODO should we make vendir's http retry within App CR, to avoid
-# transient failure when Service=>Deployment networking is not ready?
----
-apiVersion: batch/v1
-kind: Job
-metadata:
-  name: check-nginx-conn
-  namespace: default
-  annotations:
-    kapp.k14s.io/update-strategy: always-replace
-    kapp.k14s.io/change-rule: upsert after upserting server
-spec:
-  backoffLimit: 0
-  template:
-    metadata:
-      name: check-nginx-conn
-    spec:
-      containers:
-      - name: check
-        image: busybox
-        command:
-        - /bin/sh
-        - "-c"
-        - |
-          wget --tries=10 --no-check-certificate https://https-svc.https-server.svc.cluster.local/deployment.yml
-      restartPolicy: Never