Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated nginx image tag to fix e2e test failure #1252

Merged
merged 1 commit into from
Jun 20, 2023

Conversation

kumaritanushree
Copy link
Contributor

@kumaritanushree kumaritanushree commented Jun 20, 2023

What this PR does / why we need it:

E2E test is failing due to some change in nginx:latest image.
Logs from nginx pod:

$ kubectl logs -f self-signed-https-server-55545b4b7b-nsq5t -n https-server
/docker-entrypoint.sh: /docker-entrypoint.d/ is not empty, will attempt to perform configuration
/docker-entrypoint.sh: Looking for shell scripts in /docker-entrypoint.d/
/docker-entrypoint.sh: Launching /docker-entrypoint.d/10-listen-on-ipv6-by-default.sh
10-listen-on-ipv6-by-default.sh: info: /etc/nginx/conf.d/default.conf is not a file or does not exist
/docker-entrypoint.sh: Sourcing /docker-entrypoint.d/15-local-resolvers.envsh
/docker-entrypoint.sh: Launching /docker-entrypoint.d/20-envsubst-on-templates.sh
/docker-entrypoint.sh: Launching /docker-entrypoint.d/30-tune-worker-processes.sh
/docker-entrypoint.sh: Configuration complete; ready for start up
2023/06/20 10:16:39 [emerg] 1#1: unknown directive "ssl" in /etc/nginx/nginx.conf:9
nginx: [emerg] unknown directive "ssl" in /etc/nginx/nginx.conf:9

To fix this e2e test failure updated test to use tag nginx:1.10

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?


Additional Notes for your reviewer:

Review Checklist:
  • Follows the developer guidelines
  • Relevant tests are added or updated
  • Relevant docs in this repo added or updated
  • Relevant carvel.dev docs added or updated in a separate PR and there's
    a link to that PR
  • Code is at least as readable and maintainable as it was before this
    change

Additional documentation e.g., Proposal, usage docs, etc.:


@kumaritanushree kumaritanushree changed the title Updated nginx image tag to fix test failure Updated nginx image tag to fix e2e test failure Jun 20, 2023
Copy link
Member

@praveenrewar praveenrewar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for looking into it :)

@kumaritanushree kumaritanushree merged commit 6a32120 into develop Jun 20, 2023
11 checks passed
@kumaritanushree
Copy link
Contributor Author

/cherry-pick v0.41.x

@kumaritanushree
Copy link
Contributor Author

/cherry-pick v0.44.x

@github-actions github-actions bot added the carvel-triage This issue has not yet been reviewed for validity label Jun 20, 2023
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Jun 20, 2023
Updated nginx image tag to fix e2e test failure
@kumaritanushree
Copy link
Contributor Author

/cherry-pick v0.45.x

@kumaritanushree
Copy link
Contributor Author

/cherry-pick v0.46.x

gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Jun 20, 2023
Updated nginx image tag to fix e2e test failure
sethiyash added a commit that referenced this pull request Jun 20, 2023
Merge pull request #1252 from carvel-dev/update-nginx-img-in-test

Updated nginx image tag to fix e2e test failure
kumaritanushree added a commit that referenced this pull request Jun 20, 2023
Merge pull request #1252 from carvel-dev/update-nginx-img-in-test

Updated nginx image tag to fix e2e test failure
kumaritanushree added a commit that referenced this pull request Jun 20, 2023
Merge pull request #1252 from carvel-dev/update-nginx-img-in-test

Updated nginx image tag to fix e2e test failure
kumaritanushree added a commit that referenced this pull request Jun 20, 2023
Merge pull request #1252 from carvel-dev/update-nginx-img-in-test

Updated nginx image tag to fix e2e test failure
@praveenrewar praveenrewar deleted the update-nginx-img-in-test branch June 20, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
carvel-triage This issue has not yet been reviewed for validity
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants