Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make bits of kctrl more configurable #1426

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Make bits of kctrl more configurable #1426

merged 1 commit into from
Jan 3, 2024

Conversation

100mik
Copy link
Contributor

@100mik 100mik commented Dec 15, 2023

Which issue(s) this PR fixes:

Fixes #1425

Review Checklist:
  • Follows the developer guidelines
  • Relevant tests are added or updated
  • Relevant docs in this repo added or updated
  • Relevant carvel.dev docs added or updated in a separate PR and there's
    a link to that PR
  • Code is at least as readable and maintainable as it was before this
    change

Additional documentation e.g., Proposal, usage docs, etc.:

@100mik 100mik force-pushed the additional-config-command-tree branch from 242534d to d984dcd Compare December 15, 2023 10:54
praveenrewar
praveenrewar reviewed Dec 15, 2023
View reviewed changes
cli/pkg/kctrl/cmd/core/examples.go Outdated Show resolved Hide resolved
cli/pkg/kctrl/cmd/core/kubeconfig_flags.go Outdated Show resolved Hide resolved
cli/pkg/kctrl/cmd/core/secure_namespace_flags.go Outdated Show resolved Hide resolved
cli/pkg/kctrl/cmd/kctrl.go Outdated Show resolved Hide resolved
cli/pkg/kctrl/cmd/package/installed/delete.go Outdated Show resolved Hide resolved
@100mik 100mik force-pushed the additional-config-command-tree branch 5 times, most recently from 843152f to 56de416 Compare December 20, 2023 12:02
@100mik 100mik force-pushed the additional-config-command-tree branch from 56de416 to 610f456 Compare December 26, 2023 13:12
@100mik 100mik force-pushed the additional-config-command-tree branch from 610f456 to dafd27e Compare December 28, 2023 09:28
praveenrewar
praveenrewar reviewed Dec 28, 2023
View reviewed changes
cli/pkg/kctrl/cmd/core/wait_flags.go Outdated Show resolved Hide resolved
cli/pkg/kctrl/cmd/app/delete.go Show resolved Hide resolved
cli/pkg/kctrl/cmd/app/kick.go Show resolved Hide resolved
@100mik 100mik force-pushed the additional-config-command-tree branch 2 times, most recently from 5b74eff to b843873 Compare December 28, 2023 10:07
@100mik 100mik force-pushed the additional-config-command-tree branch from b843873 to 6e27672 Compare January 2, 2024 01:26
@100mik 100mik force-pushed the additional-config-command-tree branch from 6e27672 to a796c7a Compare January 3, 2024 12:32
@100mik 100mik merged commit d4125e1 into carvel-dev:develop Jan 3, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@praveenrewar praveenrewar praveenrewar approved these changes

@prembhaskal prembhaskal prembhaskal left review comments

Assignees
No one assigned
Labels
None yet
Projects
Carvel
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make bits of kctrl more configurable
3 participants
@100mik @prembhaskal @praveenrewar