Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider path nestedness for all possible downward API values #1524

Conversation

mamachanko
Copy link
Contributor

@mamachanko mamachanko commented Apr 9, 2024

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1520

Does this PR introduce a user-facing change?


Additional Notes for your reviewer:

Review Checklist:
  • Follows the developer guidelines
  • Relevant tests are added or updated
  • Relevant docs in this repo added or updated
  • Relevant carvel.dev docs added or updated in a separate PR and there's
    a link to that PR
  • Code is at least as readable and maintainable as it was before this
    change

Additional documentation e.g., Proposal, usage docs, etc.:


Copy link
Member

@praveenrewar praveenrewar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you so much for fixing this.

@praveenrewar praveenrewar merged commit 395574c into carvel-dev:develop Apr 9, 2024
10 checks passed
@mamachanko mamachanko deleted the topic/mamachanko/develop/fix-downward-api-nested-paths branch April 9, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Cannot set nested value path via downward API
2 participants