Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add test for multiple os #65

Merged
merged 1 commit into from
May 5, 2022
Merged

Conversation

greenhandatsjtu
Copy link
Contributor

@greenhandatsjtu greenhandatsjtu commented May 5, 2022

@casbin-bot
Copy link

@smrpn @hackerchai @PsiACE @GopherJ please review

@codecov-commenter
Copy link

Codecov Report

Merging #65 (fe0f57c) into master (018d362) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #65   +/-   ##
=======================================
  Coverage   76.64%   76.64%           
=======================================
  Files           4        4           
  Lines         364      364           
=======================================
  Hits          279      279           
  Misses         85       85           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 018d362...fe0f57c. Read the comment docs.

@hsluoyz
Copy link
Member

hsluoyz commented May 5, 2022

@hackerchai @PsiACE

@hackerchai
Copy link
Member

@greenhandatsjtu Can you also make a PR to https://github.com/casbin-rs/sqlx-adapter/ ?

Copy link
Contributor

@PsiACE PsiACE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hsluoyz hsluoyz merged commit 8c8b648 into casbin-rs:master May 5, 2022
@greenhandatsjtu
Copy link
Contributor Author

@greenhandatsjtu Can you also make a PR to casbin-rs/sqlx-adapter ?

Sure, I've been working on it for a while, will make a PR this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants