Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: port 2 new test cases to jCasbin #385

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Conversation

LMay001
Copy link
Contributor

@LMay001 LMay001 commented Mar 1, 2024

add 2 test case in SyncedEnforcerUnitTest
include testSync, testStopAutoLoadPolicy
part of #367

@casbin-bot
Copy link
Member

@tangyang9464 @imp2002 please review

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 56.52174% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 69.09%. Comparing base (76e97d7) to head (0d8031e).

Files Patch % Lines
...n/java/org/casbin/jcasbin/main/SyncedEnforcer.java 56.52% 6 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #385      +/-   ##
==========================================
- Coverage   69.21%   69.09%   -0.13%     
==========================================
  Files          53       53              
  Lines        2378     2401      +23     
  Branches      419      423       +4     
==========================================
+ Hits         1646     1659      +13     
- Misses        624      630       +6     
- Partials      108      112       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hsluoyz hsluoyz changed the title fix:add 2 test case from go to java feat: port 2 new test cases to jCasbin Mar 1, 2024
@hsluoyz hsluoyz merged commit c2c0df8 into casbin:master Mar 1, 2024
3 of 5 checks passed
Copy link

github-actions bot commented Mar 1, 2024

🎉 This PR is included in version 1.50.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@LMay001 LMay001 deleted the modeltest branch March 1, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants