Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: multiple section types #375

Closed
wants to merge 7 commits into from
Closed

WIP: multiple section types #375

wants to merge 7 commits into from

Conversation

Shivansh-yadav13
Copy link
Member

ref: #311 (comment)
cherry-pick of cc58c57 and 33c784c

@casbin-bot
Copy link
Member

@Gabriel-403 @Zxilly @kingiw @nodece please review

@CLAassistant
Copy link

CLAassistant commented Jul 8, 2022 •
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ Shivansh-yadav13
❌ Gabriel-403
You have signed the CLA already but the status is still pending? Let us recheck it.

@hsluoyz
Copy link
Member

hsluoyz commented Jul 8, 2022

@Shivansh-yadav13 can you post a video containing the following pic?

image

@hsluoyz hsluoyz mentioned this pull request Jul 8, 2022
Closed
@Shivansh-yadav13
Copy link
Member Author

Screencast from 08-07-22 10:21:29 PM IST.webm
@hsluoyz

@hsluoyz
Copy link
Member

hsluoyz commented Jul 9, 2022

@Shivansh-yadav13 OK, I found it in the system, perhaps the git bot is broken.

@nodece @Zxilly plz review

Zxilly
Zxilly suggested changes Jul 16, 2022
View reviewed changes
Copy link
Contributor

@Zxilly Zxilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't modify code of StringAdapter. We should not introduce breaking change as for now.

src/coreEnforcer.ts Outdated Show resolved Hide resolved
src/coreEnforcer.ts Outdated Show resolved Hide resolved
src/coreEnforcer.ts Outdated Show resolved Hide resolved
src/coreEnforcer.ts Outdated Show resolved Hide resolved
src/persist/index.ts Outdated Show resolved Hide resolved
src/persist/stringAdapter.ts Outdated Show resolved Hide resolved
nodece
nodece suggested changes Jul 16, 2022
View reviewed changes
test/utils.ts Outdated Show resolved Hide resolved
src/persist/memoryAdapter.ts Outdated Show resolved Hide resolved
test/enforcer.test.ts Outdated Show resolved Hide resolved
test/enforcer.test.ts Outdated Show resolved Hide resolved
test/enforcer.test.ts Outdated Show resolved Hide resolved
test/enforcer.test.ts Outdated Show resolved Hide resolved
src/persist/index.ts Outdated Show resolved Hide resolved
@nodece
Copy link
Member

nodece commented Sep 14, 2022

@Shivansh-yadav13 Any updates?

@Shivansh-yadav13 Shivansh-yadav13 changed the title feat: multiple section types WIP: multiple section types Sep 15, 2022
@nodece
Copy link
Member

nodece commented Sep 16, 2022

@Shivansh-yadav13 You look like push an incorrect commit, please check this PR.

@VictrumMaximum
Copy link

Hello, is there any update on this feature? I see there was some progress, but it got overwritten by a git mistake... I am considering helping out, but I also don't want to start from scratch if I don't need to.

@Shivansh-yadav13 Shivansh-yadav13 force-pushed the mpc_master branch 2 times, most recently from 70c4433 to 04bb86f Compare October 11, 2022 04:45
@nodece
Copy link
Member

nodece commented Mar 27, 2023

Closed by #442.

@nodece nodece closed this Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zxilly Zxilly Zxilly requested changes

@nodece nodece nodece requested changes

@Gabriel-403 Gabriel-403 Awaiting requested review from Gabriel-403

@kingiw kingiw Awaiting requested review from kingiw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Shivansh-yadav13 @casbin-bot @CLAassistant @hsluoyz @nodece @VictrumMaximum @Zxilly @Gabriel-403