Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added dev status #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

added dev status #4

wants to merge 1 commit into from

Conversation

vikhari
Copy link
Member

@vikhari vikhari commented Aug 4, 2020

No description provided.

Copy link
Member

@ajnelson-nist ajnelson-nist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NACK, the patch series is not yet ready for merge. The README statement added is not substantiated by the state of the code.

  • There is no designation of the versions of CASE or UCO supported. I recommend a Git submodule pointing to CASE at the prototype release commit (3718ddf), with the submodule housed at /dependencies/CASE.
  • There is no __version__ variable in any file under the /src directory.

This stumbles into a support level we hadn't documented in our policy page, but looks to me like a "Pre-alpha" status because the code doesn't do the above two items.

This PR doesn't pass my review unless it sets development status to pre-alpha, or the code is modified to satisfy the alpha status requirements.

@regriff regriff self-requested a review August 6, 2020 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants