componentWillReceiveProps -> getDerivedStateFromProps #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caseywebdev
reviewed
Apr 17, 2019
caseywebdev
reviewed
Apr 17, 2019
also adds polyfill for older react versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
react-listuses react'scomponentWillReceivePropslifecycle, which has been deprecated in favor ofcomponentDidUpdateandgetDerivedStateFromPropsfor compatibility with async rendering (see here).This is my stab at upgrading to the concurrent rendering safe API, not really knowing how react-list works but understanding how the refactoring from
componentWillReceivePropstogetDerivedStateFromPropstypically works.This changeset attempts to maintain a good amount of backwards compatibility by polyfilling getDerivedStateFromProps using
react-lifecycles-compat. Unfortunately, react-lifecycles-compat only targets react >= 0.14.9, leaving users ofreact-listusing React between 0.14.0 and 0.14.8 out of luck.