Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on conversation in #1
This is also extending from the work in #21 enabling SnapshotTesting support (which is the default for Swift Package Manager installation).
Changes:
include
directory which simplifies setup.Notes:
TODO:
SnapshotTestCase
for SnapshotTesting. SnapshotTesting doesn't (yet, there have been many discussions...) support adding simulator details such as OS, screen size or screen scale to the image name like Uber's library does.@NickEntin - would love to hear your opinions on the work here and particularly if you have any thoughts on how to approach the two top TODOs and honestly listing all the issues with the work here that you'd want changing! Thanks 🙌