Send real frame time in Darwin clocks #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And test that it does.
|
Note that this test is disabled on iOS and tvOS as we have to run the test through XCTest and show a dummy application in order to get frame pulses. |
oldergod
approved these changes
Jul 7, 2023
| val frameTimeB = DisplayLinkClock.withFrameNanos { it } | ||
| assertThat(frameTimeA).all { | ||
| isPositive() | ||
| isLessThan(frameTimeB) |
There was a problem hiding this comment.
Is it testing that frameTimeA ran before frameTimeB? and we assume that the code is executed fast enough for it to make sense?
There was a problem hiding this comment.
Yes. Because it's nanos it's basically impossible to get two of the same values back since the precision is so high.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And test that it does.
Refs #237