use sendOption type in function argument #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Egge21M
requested changes
Nov 17, 2024
gandlafbtc
reviewed
Nov 22, 2024
callebtc
reviewed
Dec 9, 2024
Egge21M
requested changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #210
Description
Some Functions in
CashuWallettake optional paramaters, they have grown overtime, this PR move the option paramaters into a type and use the type in the function argument instead of the long object with different type,this way we can add more optional parameters in the type and still used there ever they are need in a function
...
Changes
PR Tasks
npm run test--> no failing unit testsnpm run format