Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port the changes related to handling of unbonds in global-state-update-gen to feat-2.0 #4844

Merged
merged 4 commits into from
Sep 10, 2024

Conversation

fizyk20
Copy link
Collaborator

@fizyk20 fizyk20 commented Sep 6, 2024

This ports the changes made in #4828 to feat-2.0.

@EdHastingsCasperAssociation
Copy link
Collaborator

bors r+

casperlabs-bors-ng bot added a commit that referenced this pull request Sep 9, 2024
4844: Port the changes related to handling of unbonds in `global-state-update-gen` to `feat-2.0` r=EdHastingsCasperAssociation a=fizyk20

This ports the changes made in #4828 to `feat-2.0`.

Co-authored-by: Bartłomiej Kamiński <[email protected]>
Copy link
Contributor

This PR was included in a batch that successfully built, but then failed to merge into feat-2.0. It will not be retried.

Additional information:

{"message":"Required status check \"lints\" is failing.","documentation_url":"https://docs.github.com/articles/about-protected-branches","status":"422"}

@devendran-m devendran-m added the rc-5 Release Candidate 5 label Sep 9, 2024
@fizyk20
Copy link
Collaborator Author

fizyk20 commented Sep 9, 2024

bors r+

casperlabs-bors-ng bot added a commit that referenced this pull request Sep 9, 2024
4844: Port the changes related to handling of unbonds in `global-state-update-gen` to `feat-2.0` r=fizyk20 a=fizyk20

This ports the changes made in #4828 to `feat-2.0`.

Co-authored-by: Bartłomiej Kamiński <[email protected]>
Copy link
Contributor

Build failed:

@fizyk20
Copy link
Collaborator Author

fizyk20 commented Sep 9, 2024

bors r+

casperlabs-bors-ng bot added a commit that referenced this pull request Sep 9, 2024
4844: Port the changes related to handling of unbonds in `global-state-update-gen` to `feat-2.0` r=fizyk20 a=fizyk20

This ports the changes made in #4828 to `feat-2.0`.

Co-authored-by: Bartłomiej Kamiński <[email protected]>
Copy link
Contributor

Build failed:

@fizyk20
Copy link
Collaborator Author

fizyk20 commented Sep 10, 2024

reactor::main_reactor::tests::node_should_rejoin_after_ejection seems to be flaky. It passed for me twice locally, but I can reproduce the failure with the given seed (CL_TEST_SEED=08f498218291e7059a207a4a4ff0a78a). I'll try to merge this and fix the test in a separate PR.

@fizyk20
Copy link
Collaborator Author

fizyk20 commented Sep 10, 2024

bors r+

Copy link
Contributor

Build succeeded:

@casperlabs-bors-ng casperlabs-bors-ng bot merged commit f64bab3 into casper-network:feat-2.0 Sep 10, 2024
3 checks passed
@fizyk20 fizyk20 deleted the fix-unbonds-2.0 branch September 10, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rc-5 Release Candidate 5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants