Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing TransactionV1 structure. From now on a TransactionV1 con… #4890

Conversation

zajko
Copy link

@zajko zajko commented Sep 17, 2024

…sists of hash, payload and approvals. payload is a merge of header and body concepts from before. body is not represented in a type-constrained way, instead we use an amorphic fields of type BTreeMap<u16, Bytes> which is more resistant to future changes.

@zajko zajko force-pushed the restructuring_transaction_datatype branch 4 times, most recently from 4b80341 to e4679ab Compare September 17, 2024 14:54
internal_types/Cargo.toml Outdated Show resolved Hide resolved
internal_types/Cargo.toml Outdated Show resolved Hide resolved
@zajko zajko force-pushed the restructuring_transaction_datatype branch 3 times, most recently from 92b3a87 to 9252a9b Compare September 18, 2024 12:57
@zajko zajko force-pushed the restructuring_transaction_datatype branch 11 times, most recently from ed9227d to e009a45 Compare September 27, 2024 21:34
@zajko zajko marked this pull request as ready for review September 27, 2024 21:34
@zajko zajko force-pushed the restructuring_transaction_datatype branch from 269ff6f to 43b8bcf Compare October 1, 2024 12:16
@devendran-m devendran-m added the rc-5 Release Candidate 5 label Oct 1, 2024
…s of `hash`, `payload` and `approvals`. `payload` is a merge of `header` and `body` concepts from before. `body` is not represented in a type-constrained way, instead we use an amorphic `fields` of type `BTreeMap<u16, Bytes>` which is more resistant to future changes.
@zajko zajko force-pushed the restructuring_transaction_datatype branch from 68347b0 to 078e98e Compare October 10, 2024 10:52
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'd like to get this merged...it seems basically solid, and if there remains some fit & finish we can deal with it via bug report

types/src/transaction.rs Outdated Show resolved Hide resolved
@zajko
Copy link
Author

zajko commented Oct 17, 2024

bors r+

Copy link
Contributor

Build succeeded:

@casperlabs-bors-ng casperlabs-bors-ng bot merged commit 6e9f849 into casper-network:feat-2.0 Oct 17, 2024
3 checks passed
gRoussac added a commit to casper-ecosystem/casper-client-rs that referenced this pull request Oct 17, 2024
…4890 (#191)

* merge changes

* Cargo types

* is_install_upgrade / additional_computation_factor wip

* Fix tests and additional_computation_factor

* Update json-schema
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rc-5 Release Candidate 5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants