Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the override paths when running in github actions #3045

Merged
merged 3 commits into from
Nov 27, 2023

Conversation

rousik
Copy link
Collaborator

@rousik rousik commented Nov 14, 2023

This is an independent change that is part of #2825. Trying to separate it to ensure that this doesn't affect codecov results.

@rousik rousik marked this pull request as ready for review November 27, 2023 03:55
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5eb88de) 88.7% compared to head (8f0f51c) 88.7%.
Report is 16 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##             dev   #3045     +/-   ##
=======================================
- Coverage   88.7%   88.7%   -0.1%     
=======================================
  Files         90      90             
  Lines      10995   10995             
=======================================
- Hits        9759    9758      -1     
- Misses      1236    1237      +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zaneselvans zaneselvans merged commit 649db02 into dev Nov 27, 2023
15 of 16 checks passed
@zaneselvans zaneselvans deleted the fix-conftest-bug branch November 28, 2023 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants