[#136] Sort by cumulative faildelay

catalyst · Oct 9, 2023 · 5648516 · 5648516
1 parent 004e3bb
commit 5648516
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/croncheck.php b/croncheck.php
@@ -229,10 +229,11 @@
 
 // Instead of using task API here, we read directly from the database.
 // This stops errors originating from broken tasks, and allows the DB to de-duplicate them.
-$adhoctasks = $DB->get_records_sql("  SELECT classname, COUNT(*) count, MAX(faildelay) faildelay
+$adhoctasks = $DB->get_records_sql("  SELECT classname, COUNT(*) count, MAX(faildelay) faildelay, SUM(faildelay) cfaildelay
                                        FROM {task_adhoc}
                                       WHERE faildelay > 0
-                                   GROUP BY classname");
+                                   GROUP BY classname
+                                   ORDER BY cfaildelay DESC");
 
 foreach ($adhoctasks as $record) {
     // Only add duplicate message if there are more than 1.