Issues 633 634-MOODLE_402_STABLE #638
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -110,6 +110,9 @@ | |||
| new lang_string('settings:tokenexpirywarnperiod', 'tool_objectfs'), | |||
| '', 60 * DAYSECS, DAYSECS)); | |||
|
|
|||
| $settings->add(new admin_setting_configcheckbox('tool_objectfs/preferexternal', | |||
There was a problem hiding this comment.
why have the settings changed?
| $path = $this->get_external_path_from_hash($contenthash, false); | ||
|
|
||
| if ($contenthash === sha1('') && is_dir($path)) { | ||
| // Explicitly check if it is a directory, handle empty files as normal. | ||
| // We handle these virtually. | ||
| return true; |
There was a problem hiding this comment.
wouldn't it be better to simply say no this file isn't readable externally, so false here? get_external_path_from_hash is more expensive so I think this should come after the sha1 test like it was
|
Created new pr #639 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #633 and #634