Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use pnpm instead of yarn #3

Merged
merged 6 commits into from
Mar 7, 2024
Merged

feat: use pnpm instead of yarn #3

merged 6 commits into from
Mar 7, 2024

Conversation

reednaa
Copy link
Member

@reednaa reednaa commented Mar 7, 2024

No description provided.

@reednaa reednaa requested a review from jsanmigimeno March 7, 2024 12:21
@jsanmigimeno
Copy link
Member

I'm getting the following warning when running the image, not sure if it will cause problems.
image

Copy link
Member

@jsanmigimeno jsanmigimeno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • README should be update (yarn installation)

dockerfile.relayer Outdated Show resolved Hide resolved
@reednaa
Copy link
Member Author

reednaa commented Mar 7, 2024

I'm getting the following warning when running the image, not sure if it will cause problems. image

The bigint error is emitted here: https://www.npmjs.com/package/bigint-buffer?activeTab=code

It is supposedly because the C bindings wasn't compiled correctly. However, I don't understand why the bindings wasn't compiled. Maybe because there is a requirement on the dev dependencies that enable compiling?

I always had that secp256k1 error because of cryptocoinjs/secp256k1-node#173

I will try changing the dockerfile to use prune and see if that helps.

@reednaa
Copy link
Member Author

reednaa commented Mar 7, 2024

It helps. I will undo the prune removal.

Copy link
Member

@jsanmigimeno jsanmigimeno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@reednaa reednaa merged commit c00e831 into main Mar 7, 2024
1 check passed
@jsanmigimeno jsanmigimeno deleted the pnpm-cache branch July 25, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants