fix: BUG 131913 stop losing the filter text when filtering the test history #2952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alectejada
added
the
Type: Bug
jefflembeck
reviewed
Jul 19, 2023
| @@ -52,7 +55,7 @@ | |||
| 'local' => isset($_REQUEST['local']) && $_REQUEST['local'], | |||
| 'body_class' => 'history', | |||
| 'page_title' => 'WebPageTest - Test History', | |||
|
|
|||
| 'filter' => $filterstr | |||
There was a problem hiding this comment.
I know you have the regex above, but I'd just use htmlspecialchars() https://www.php.net/htmlspecialchars
There was a problem hiding this comment.
hey jeff since its being rendered on a blade template it should be going through this function already, should we add anyway?
There was a problem hiding this comment.
oh that's right! nice catch. spaced the whole "this is on blade" thing.
jefflembeck
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this change will prevent losing the text the user has on the text input when filtering the test history, it does so by making sure we keep it on the url query