Fix kafka internal docker connection #1
Conversation
* Fix trailing slash on Image Prefix * Apply Lint fix
…ainers#2753) * Upgrade milvus-io/milvus-sdk-go to avoid checksum mismatch. * Update go.sum * Update indirect dependencies.
) * fix: check if the discovered docker socket responds * fix: update tests * chore: add test * Revert "chore: add test" This reverts commit c6c4832. * Revert "fix: update tests" This reverts commit fbadada. * Revert "fix: check if the discovered docker socket responds" This reverts commit 19fb55b. * chore: support passing callback checks to the docker host/socket path resolution This way the tests are able to verify if the socket/host is reachable by calling a mock client. The production code will use the default callback check, which calls a vanilla docker client using the discovered host as host * chore: convert var into function * chore: mock callback check instead * chore: simplify * chore: raise error when extracting the docker host * docs: document that the extract functions panics * chore: simplify error handler * chore: use require.Panics * fix: remove duplicated case * fix: negotiate API version in the plain docker client call * fix: defer closing the client earlier * chore: better function name * chore: convert vars into functions * chore: no need to assert as panic should occur * chor: rename check function * chore: pass ctx to new function * chore: more exhaustive error check in tests * docs: typo * fix: update usage
…estcontainers#2760) Bumps [mkdocs-include-markdown-plugin](https://github.com/mondeja/mkdocs-include-markdown-plugin) from 6.0.4 to 6.2.2. - [Release notes](https://github.com/mondeja/mkdocs-include-markdown-plugin/releases) - [Commits](mondeja/mkdocs-include-markdown-plugin@v6.0.4...v6.2.2) --- updated-dependencies: - dependency-name: mkdocs-include-markdown-plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…s#2762) Bumps [actions/checkout](https://github.com/actions/checkout) from 4.1.1 to 4.1.7. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@b4ffde6...692973e) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…testcontainers#2761) Bumps [mkdocs-markdownextradata-plugin](https://github.com/rosscdh/mkdocs-markdownextradata-plugin) from 0.2.5 to 0.2.6. - [Release notes](https://github.com/rosscdh/mkdocs-markdownextradata-plugin/releases) - [Commits](rosscdh/mkdocs-markdownextradata-plugin@0.2.5...0.2.6) --- updated-dependencies: - dependency-name: mkdocs-markdownextradata-plugin dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This commit allows users of the compose module to selectively enable services by using Docker Compose profiles. More about profiles: https://docs.docker.com/compose/profiles
* feat(wait): for file Add the ability to wait for a file and optionally its contents. This leverages generated mocks using mockery and testify/mock to make testing easier. * debugging: rate limit config dump Add output of the docker config if we hit rate limiting to aid in debugging why this is happening on github actions. Don't use logger as that's no-op when verbose is not in effect. * docs: list the file wait strategy in docs --------- Co-authored-by: Manuel de la Peña <[email protected]>
* docs: refine heading badges in README * docs: consistency across langs
* main: docs: refine heading badges in README (testcontainers#2770) feat(wait): for file (testcontainers#2731) feat(compose): select services via profiles (testcontainers#2758) chore(deps): bump mkdocs-markdownextradata-plugin from 0.2.5 to 0.2.6 (testcontainers#2761) fix: update template too (testcontainers#2763) chore(deps): bump actions/checkout from 4.1.1 to 4.1.7 (testcontainers#2762) chore(deps): bump mkdocs-include-markdown-plugin from 6.0.4 to 6.2.2 (testcontainers#2760) fix: check if the discovered docker socket responds (testcontainers#2741) Upgrade milvus-io/milvus-sdk-go to avoid checksum mismatch. (testcontainers#2753) Fix trailing slash on Image Prefix (testcontainers#2747) chore: use new testcontainers/ryuk:0.9.0 image (testcontainers#2750)
|
LGTM |
|
@catinapoke how do you want to proceed with this? Merge into your branch and then add kcat to those tests? |
|
Yes, going to redo test with kcat |
|
Btw, have you run tests? I see my tests fail now at basic stuff :/ |
|
uhm, yea, I see in Github tests details 2024/09/09 18:10:15 🐳 Starting container: c5830d4ef694 === FAIL: . TestTrimValidateListeners/testcontainers#3 (re-run 5) (0.00s) === FAIL: . TestTrimValidateListeners (re-run 5) (0.00s) === FAIL: . TestKafka (re-run 5) (5.27s) |
|
@mdelapenya looks like something has been broken after your changes (or before your and after mine, I dunno) upd. fixed basic test for kafka, but network one is still broken |
Hey @catinapoke, I'm sending a PR to your main branch (the one you used to send the original PR).
What does this PR do?
This PR is merging the current state of main with the branch, adding commits for:
initKafkaTestuntouched on purpose, I hope you can work on that replacing the current logic with the kcat example. 🙏I think there are other tests needing the kcat
Why is it important?
Unblock testcontainers#2490
Related issues