-
-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(focus): init #1209
base: main
Are you sure you want to change the base?
feat(focus): init #1209
Conversation
I think it's ready, i just missed a few lol should be ready to merge now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't really test this but the CSS looks good
Did you test the UI? |
You need to say that when reviewing? Or just don't approve if you haven't tested the entire application. |
#userwayAccessibilityIcon { | ||
img { | ||
background-color: @blue !important; | ||
border-radius: 50%; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does this need to be set?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does it look like with the userstyle not applied? Or with the userstyle applied but the border radius commented out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm lost on why you need to set the border radius. Try https://github.com/catppuccin/userstyles/blob/main/docs/tips-and-tricks.md#how-do-i-theme-images-and-svgs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't seem to work for some reason, even directly on the image element
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please stop resolving this thread of an ongoing conversation.
im banned from my school's auth portal so i cant test catppuccin focus 💀 |
im literally the only other focus user |
looks good @IncognitoTGT but file uploads, and tables are broken |
I'll take a look at this one, the schedule table couldn't be styled no matter what I tried so I didn't touch that one. I don't have access to these, can you send me the markup tree or the css classes that need to be styled for this? |
reopening of #1205 as I messed up the branch
🎉 Theme for Focus 🎉
Focus is a Student information System used by schools to manage student information, such as grades, classes, and enrollment.
💬 Additional Comments 💬
CSS classes are really weird and I ended up using a lot of !important, and I had to make an outline for the background to extend on the homepage.
Also, the preview image has things blurred as using the font did not apply everywhere, as the site's css uses !important way more than it should.
🗒 Checklist 🗒
/styles/<name-of-website>
containing the contents of the/template
directory.userstyles.yml
file with information about the new userstyle.
catppuccin.user.css
- all the CSS for the userstyle, based on thetemplate.
preview.webp
- composite image of all four individual flavor screenshots (taken with the default accent color of mauve) stitched together, generated via Catwalk.