fix(anilist): change text-bright, cleanup #1458
Conversation
| // Scrollbar color | ||
| * { | ||
| scrollbar-color: @catppuccin[@@lightFlavor][@@accentColor] | ||
| fade(@catppuccin[@@darkFlavor][@crust], 0.2); | ||
| &:has(.site-theme-dark) { | ||
| scrollbar-color: @catppuccin[@@darkFlavor][@@accentColor] | ||
| fade(@catppuccin[@@darkFlavor][@crust], 0.2); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
I'm not completely sure if this will be fine performance-wise, but it's the only way I could style the scrollbars.
There was a problem hiding this comment.
Why does it need to be applied to every single element? And why is this not in the #catppuccin mixin?
There was a problem hiding this comment.
The userstyle uses the body element to select dark and light flavors, which unfortunately results in the scrollbar (Which is styled using the * selector) not being themed. It's the only way I could figure out a workaround, however I'm open to any changes.
| // Scrollbar color | ||
| * { | ||
| scrollbar-color: @catppuccin[@@lightFlavor][@@accentColor] | ||
| fade(@catppuccin[@@darkFlavor][@crust], 0.2); | ||
| &:has(.site-theme-dark) { | ||
| scrollbar-color: @catppuccin[@@darkFlavor][@@accentColor] | ||
| fade(@catppuccin[@@darkFlavor][@crust], 0.2); | ||
| } | ||
| } |
There was a problem hiding this comment.
Sorry for taking forever to review this PR. Would you mind updating the PR to modify the Less file, and can we move this section under the #catppuccin mixin? I'm not sure why we need to put it out here and repeat the @catppuccin[@@lightFlavor][@@accentColor] stuff.
uncenter
added
the
waiting on author
Changes default value of
--color-text-bright, removes redundant styling