Address outstanding issues #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h no docstring. Introduces a way to peek at the next item of the siblings when iterating, without letting the generator increment past that item.
We use tokenize to parse python tokens, but since we can start the parser on a line in the middle of the file, it doesn't have indentation context from previous lines and can throw an IndentationError. In these cases we can safely catch and stop iteration since we haven't found the tokens we are looking for anyway.
cbillingham
force-pushed
the
cam/issues
branch
from
e97233a
to
8246148
Compare
…nce its no longer supported
cbillingham
force-pushed
the
cam/issues
branch
from
8246148
to
f56f726
Compare
|
Ha github actions dropped python2.7. I suppose we should as well. I did test locally in 2.7 for kicks and made few changes so it was compatible. Still works in 2.7 technically but we should probably just drop support I think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally got around to addressing our outstanding issues
Also fixed a strange ast parsing bug I encountered where assign nodes were skipping the following sibling.