Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show error in wget on http.get error #2037

Merged
merged 3 commits into from
Dec 22, 2024
Merged

Show error in wget on http.get error #2037

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3a7de2f
Show error in wget on http.get error
tizu69 Dec 21, 2024
64a4a53
fix: wget error handling print() wraps, I'm braindead
tizu69 Dec 21, 2024
f606119
Use printError(..) to display the message
SquidDev Dec 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions projects/core/src/main/resources/data/computercraft/lua/rom/programs/http/wget.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,20 +35,20 @@ local function getFilename(sUrl)
return sUrl:match("/([^/]+)$")
end

local function get(sUrl)
local function get(url)
-- Check if the URL is valid
local ok, err = http.checkURL(url)
if not ok then
printError(err or "Invalid URL.")
return
end

write("Connecting to " .. sUrl .. "... ")
write("Connecting to " .. url .. "... ")

local response = http.get(sUrl)
local response, err = http.get(url)
if not response then
print("Failed.")
return nil
printError(err)
return
end

print("Success.")
Expand Down
Loading