Update needed for Django 4.2.3 #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evan-CTL
force-pushed
the
django-4.2.3
branch
2 times, most recently
from
61aafda
to
a16ecb8
Compare
nikolas
reviewed
Aug 1, 2023
CHANGES.txt
Outdated
| @@ -1,4 +1,8 @@ | |||
| 2.4.0 | |||
| 2.5.0 (2023-08-01) | |||
There was a problem hiding this comment.
The current version on pypi is version 2.3.0, so I suggest the next version we release will be 2.4.0.
nikolas
reviewed
Aug 1, 2023
CHANGES.txt
Outdated
| 2.4.0 | ||
| 2.5.0 (2023-08-01) | ||
| ==================== | ||
| * Prioritize urllib.parse.quote import over deprecated django.utils.http.urlquote |
There was a problem hiding this comment.
Also, it's good to note in the changelog here that this adds compatibility with Django 4.2.
Evan-CTL
force-pushed
the
django-4.2.3
branch
2 times, most recently
from
ebe4110
to
1825349
Compare
nikolas
reviewed
Aug 1, 2023
courseaffils/tests/urls.py
Outdated
| url(r'^course/create/$', | ||
| views.CourseCreateView.as_view(), | ||
| name='create_course'), | ||
| re_path(r'^select_course/$', |
There was a problem hiding this comment.
Because these routes don't appear to be using any regex-specific stuff, just using the more standard path should work as well:
path('select_course/',
views.CourseListView.as_view(),
name='select_course'),
nikolas
reviewed
Aug 1, 2023
setup.py
Outdated
| @@ -1,13 +1,13 @@ | |||
| from setuptools import setup, find_packages | |||
|
|
|||
| version = '2.3.0' | |||
| version = '2.5.0' | |||
There was a problem hiding this comment.
Version number here should be changed to 2.4.0
There was a problem hiding this comment.
Right forgot to change that back
nikolas
reviewed
Aug 1, 2023
| @@ -37,7 +37,6 @@ | |||
| 'django.contrib.contenttypes', | |||
| 'django.contrib.sessions', | |||
| 'courseaffils', | |||
| 'django_markwhat', | |||
There was a problem hiding this comment.
We can remove django-markwhat from test_reqs.txt as well in this PR, if you're removing it here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.