This repository has been archived by the owner on Apr 16, 2024. It is now read-only.
Replace Atoum with PHPUnit #114
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cconard96
force-pushed
the
feature/prep_phpunit
branch
from
5aeade0 to
2d5ee34
Compare
cconard96
force-pushed
the
feature/prep_phpunit
branch
from
2ccc97e to
8ed1825
Compare
|
Replaced by #147 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace Atoum with PHPUnit for tests.
Initially, a shim library will be used to allow running the existing Atoum tests in the PHPUnit engine so I don't have to work with the Atoum engine anymore.
Next, tests will be fixed.
Finally, the Atoum assertions will be changed to the native PHPUnit equivalents and the shim will be dropped and replaced with just PHPUnit. A GitHub action will also be added to automatically run the test suite for pull requests.