Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ReserveSpace parameter to StorageClass #103

Merged
merged 5 commits into from
Aug 13, 2023

Conversation

Foxite
Copy link
Contributor

@Foxite Foxite commented Aug 10, 2023

Summary

Checklist

For Helm Chart changes

  • Categorize the PR by setting a good title and adding one of the labels:
    kind:bug, kind:enhancement, kind:documentation, kind:change, kind:breaking, kind:dependency
    as they show up in the changelog
  • PR contains the label area:chart
  • PR contains the chart label, e.g. chart:kubernetes-zfs-provisioner
  • Variables are documented in the values.yaml using the format required by Helm-Docs.
  • Chart Version bumped if immediate release after merging is planned
  • I have run make chart-docs
  • Link this PR to related code release or other issues.

@Foxite
Copy link
Contributor Author

Foxite commented Aug 10, 2023

Do you think this requires manual testing?

@ccremer ccremer changed the title helm chart update for #102 Add ReserveSpace parameter to StorageClass Aug 11, 2023
@ccremer
Copy link
Owner

ccremer commented Aug 11, 2023

Do you think this requires manual testing?

If you like, you can add unit test in Go to see if the parameters applied are rendered correctly, see the test folder within the chart.
https://github.com/ccremer/kubernetes-zfs-provisioner/blob/master/charts/kubernetes-zfs-provisioner/test/storageclass_test.go

Copy link
Owner

@ccremer ccremer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR :)

Have you run the command to generate the Chart readme? It seems to be missing, as well as the version bump in chart.yaml

@Foxite
Copy link
Contributor Author

Foxite commented Aug 11, 2023

I just ran make chart-docs but nothing changed.

What version should I bump to?

@ccremer
Copy link
Owner

ccremer commented Aug 12, 2023

What version should I bump to?

Since this is a new feature, version 2.2.0 would be next
https://github.com/ccremer/kubernetes-zfs-provisioner/blob/master/charts/kubernetes-zfs-provisioner/Chart.yaml

I just ran make chart-docs but nothing changed.

It should update the readme after you bump the version IIRC

@Foxite
Copy link
Contributor Author

Foxite commented Aug 12, 2023

All done!

@ccremer ccremer merged commit 3efc732 into ccremer:master Aug 13, 2023
5 checks passed
@ccremer
Copy link
Owner

ccremer commented Aug 13, 2023

Merged & released.
Thanks for the PRs :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants