Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loading of environment variables #129

Merged
merged 1 commit into from
Aug 3, 2024
Merged

Fix loading of environment variables #129

merged 1 commit into from
Aug 3, 2024

Conversation

ccremer
Copy link
Owner

@ccremer ccremer commented Aug 3, 2024

Summary

  • Removes Go dependency to koanf
  • It's not really worth having a 3rd party lib for 4 settings, when only env vars are used.
  • Actually fixes loading of environment variables, and displays them at startup.

Replaces #121

Checklist

For Code changes

  • Categorize the PR by setting a good title and adding one of the labels:
    kind:bug, kind:enhancement, kind:documentation, kind:change, kind:breaking, kind:dependency
    as they show up in the changelog
  • PR contains the label area:provisioner
  • Link this PR to related issues
  • I have not made any changes in the charts/ directory.

@ccremer ccremer added kind:bug Something isn't working area:provisioner labels Aug 3, 2024
Not really worth having a 3rd party lib for 4 settings, when only env vars are used.
@ccremer ccremer marked this pull request as ready for review August 3, 2024 10:10
@ccremer ccremer merged commit 829d4a5 into master Aug 3, 2024
3 checks passed
@ccremer ccremer deleted the remove-koanf branch August 3, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:provisioner kind:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant