Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update module github.com/knadh/koanf to v2 #96

Merged
merged 2 commits into from
Aug 13, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Mar 16, 2023

Mend Renovate

This PR contains the following updates:

Package Type Update Change
github.com/knadh/koanf require major v1.5.0 -> v2.0.1
  • PR contains the label that identifies the area, one of: area:provisioner, area:chart
  • If the PR is targeting a Helm chart, add the chart label, e.g. chart:kubernetes-zfs-provisioner

Release Notes

knadh/koanf (github.com/knadh/koanf)

v2.0.1

Compare Source

What's Changed

New Contributors

Full Changelog: knadh/koanf@v2.0.0...v2.0.1

v2.0.0

Compare Source

This is a major breaking change that ends koanf v1 (v1.5.0) and moves to v2. Continued usage of v1 is unaffected. While koanf does not bundle external dependencies into its core thereby avoiding them in the build, a go get would still pull them and go.mod, bringing in unnecessary references as all the providers and parsers were "sub" packages of the main module.

This PR upgrades koanf to v2 and separates every single provider and parser package into its own module, go.mod, and release tag (eg: providers/yaml/v0.1.0). That is, one-repository, many modules. This removes references to all indirect dependencies in the main koanf package significantly de-cluttering it.

What changes?
  • Going forward, koanf references should change to github.com/knadh/koanf/v2.
  • The required parsers and providers should be installed explicitly as they do not come bundled with the main koanf package anymore. Eg: go get github.com/knadh/koanf/providers/s3, go get github.com/knadh/koanf/parsers/json etc.
  • That's all. There is no change in functionality.

Full Changelog: knadh/koanf@v1.5.0...v2.0.0


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate
Copy link
Contributor Author

renovate bot commented Mar 16, 2023

⚠ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: go.sum
Command failed: docker run --rm --name=renovate_a_sidecar --label=renovate_a_child --memory=3584m -v "/tmp/worker/c5cd25/f1a77c/repos/github/ccremer/kubernetes-zfs-provisioner":"/tmp/worker/c5cd25/f1a77c/repos/github/ccremer/kubernetes-zfs-provisioner" -v "/tmp/worker/c5cd25/f1a77c/cache":"/tmp/worker/c5cd25/f1a77c/cache" -e GOPATH -e GOPROXY -e GOSUMDB -e GOFLAGS -e CGO_ENABLED -e GIT_CONFIG_KEY_0 -e GIT_CONFIG_VALUE_0 -e GIT_CONFIG_KEY_1 -e GIT_CONFIG_VALUE_1 -e GIT_CONFIG_KEY_2 -e GIT_CONFIG_VALUE_2 -e GIT_CONFIG_COUNT -e CONTAINERBASE_CACHE_DIR -w "/tmp/worker/c5cd25/f1a77c/repos/github/ccremer/kubernetes-zfs-provisioner" ghcr.io/containerbase/sidecar:9.9.1 bash -l -c "install-tool golang 1.21.0 && go get -d -t ./..."
/usr/local/bin/docker: line 4: .: filename argument required
.: usage: . filename [arguments]
go: downloading k8s.io/api v0.27.4
go: downloading k8s.io/apimachinery v0.27.4
go: downloading k8s.io/klog/v2 v2.100.1
go: downloading sigs.k8s.io/sig-storage-lib-external-provisioner/v9 v9.0.3
go: downloading github.com/mistifyio/go-zfs/v3 v3.0.1
go: downloading github.com/stretchr/testify v1.8.4
go: downloading k8s.io/client-go v0.27.4
go: downloading github.com/gogo/protobuf v1.3.2
go: downloading github.com/google/gofuzz v1.1.0
go: downloading github.com/go-logr/logr v1.2.3
go: downloading github.com/prometheus/client_golang v1.11.1
go: downloading golang.org/x/time v0.0.0-20220210224613-90d013bbcef8
go: downloading github.com/google/uuid v1.3.0
go: downloading github.com/davecgh/go-spew v1.1.1
go: downloading github.com/pmezard/go-difflib v1.0.0
go: downloading gopkg.in/yaml.v3 v3.0.1
go: downloading github.com/stretchr/objx v0.5.0
go: downloading gopkg.in/inf.v0 v0.9.1
go: downloading github.com/imdario/mergo v0.3.6
go: downloading github.com/spf13/pflag v1.0.5
go: downloading golang.org/x/term v0.6.0
go: downloading k8s.io/utils v0.0.0-20230209194617-a36077c30491
go: downloading sigs.k8s.io/structured-merge-diff/v4 v4.2.3
go: downloading github.com/prometheus/client_model v0.2.0
go: downloading github.com/prometheus/common v0.26.0
go: downloading github.com/beorn7/perks v1.0.1
go: downloading github.com/cespare/xxhash/v2 v2.1.1
go: downloading github.com/golang/protobuf v1.5.3
go: downloading golang.org/x/sys v0.6.0
go: downloading github.com/prometheus/procfs v0.6.0
go: downloading github.com/golang/groupcache v0.0.0-20210331224755-41bb18bfe9da
go: downloading github.com/miekg/dns v1.1.41
go: downloading github.com/google/gnostic v0.5.7-v3refs
go: downloading golang.org/x/net v0.8.0
go: downloading sigs.k8s.io/json v0.0.0-20221116044647-bc3834ca7abd
go: downloading github.com/json-iterator/go v1.1.12
go: downloading gopkg.in/yaml.v2 v2.4.0
go: downloading github.com/matttproud/golang_protobuf_extensions v1.0.1
go: downloading google.golang.org/protobuf v1.28.1
go: downloading github.com/google/go-cmp v0.5.9
go: downloading k8s.io/kube-openapi v0.0.0-20230501164219-8b0f38b5fd1f
go: downloading golang.org/x/oauth2 v0.0.0-20220223155221-ee480838109b
go: downloading sigs.k8s.io/yaml v1.3.0
go: downloading github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd
go: downloading github.com/modern-go/reflect2 v1.0.2
go: downloading github.com/munnerz/goautoneg v0.0.0-20191010083416-a7dc8b61c822
go: downloading golang.org/x/text v0.8.0
go: downloading github.com/go-openapi/swag v0.22.3
go: downloading github.com/go-openapi/jsonreference v0.20.1
go: downloading github.com/emicklei/go-restful/v3 v3.9.0
go: downloading google.golang.org/appengine v1.6.7
go: downloading github.com/go-openapi/jsonpointer v0.19.6
go: downloading github.com/mailru/easyjson v0.7.7
go: downloading github.com/josharian/intern v1.0.0
go: downloading github.com/knadh/koanf/providers/confmap v0.1.0
go: downloading github.com/knadh/koanf v1.5.0
go: downloading github.com/knadh/koanf/providers/env v0.1.0
go: downloading github.com/mitchellh/copystructure v1.2.0
go: downloading github.com/mitchellh/mapstructure v1.5.0
go: downloading github.com/mitchellh/reflectwalk v1.0.2
go: github.com/ccremer/kubernetes-zfs-provisioner imports
	github.com/knadh/koanf/providers/confmap: ambiguous import: found package github.com/knadh/koanf/providers/confmap in multiple modules:
	github.com/knadh/koanf v1.5.0 (/go/pkg/mod/github.com/knadh/[email protected]/providers/confmap)
	github.com/knadh/koanf/providers/confmap v0.1.0 (/go/pkg/mod/github.com/knadh/koanf/providers/[email protected])
go: github.com/ccremer/kubernetes-zfs-provisioner imports
	github.com/knadh/koanf/providers/env: ambiguous import: found package github.com/knadh/koanf/providers/env in multiple modules:
	github.com/knadh/koanf v1.5.0 (/go/pkg/mod/github.com/knadh/[email protected]/providers/env)
	github.com/knadh/koanf/providers/env v0.1.0 (/go/pkg/mod/github.com/knadh/koanf/providers/[email protected])

@renovate renovate bot force-pushed the renovate/github.com-knadh-koanf-2.x branch from 3b9e51e to 1916f52 Compare April 17, 2023 13:27
@renovate renovate bot force-pushed the renovate/github.com-knadh-koanf-2.x branch from 1916f52 to 4e7b40b Compare August 13, 2023 07:24
@renovate renovate bot force-pushed the renovate/github.com-knadh-koanf-2.x branch from 4e7b40b to 3eda5c1 Compare August 13, 2023 07:39
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate renovate bot force-pushed the renovate/github.com-knadh-koanf-2.x branch from 3eda5c1 to eaa4077 Compare August 13, 2023 08:29
@renovate
Copy link
Contributor Author

renovate bot commented Aug 13, 2023

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@ccremer ccremer merged commit 33d0a2c into master Aug 13, 2023
3 checks passed
@ccremer ccremer deleted the renovate/github.com-knadh-koanf-2.x branch August 13, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant