Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a base class for scorers #34

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

EpsIotaPi
Copy link
Contributor

I create a base class for scorers, and I think this change could simplified the scorers' structures

@cdimascio
Copy link
Owner

thanks @EpsIotaPi this looks great.
one call out score vs raw_score changes the public api, correct?
can we continue to call it score for backward compatibility

@EpsIotaPi
Copy link
Contributor Author

I change the raw_score to score in class Result. Hope this change could solve the backward compatibility problem ~

Copy link
Owner

@cdimascio cdimascio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks good. However, the fact that score is replaced with results makes this a breaking change.

All in all, this is ok. I'll do a new major version version.

The readme needs a refresh to reflect the new results API. Once the readme updates are in the PR, I'll get this merged

Thanks for you're work here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants