chore: fix the script upgrading the aws cli version #958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was previously using sed. Which is fine, but sed behaves differently on Linux and macOs. So I wasted a bunch of time trying to understand why it's working locally but not in GitHub Action. Having scripts behave differently in different environments isn't great. So instead of fixing the sed command, this is now using python only.
iliapolo
approved these changes
Sep 23, 2024
mergify
bot
deleted the
mrgrain/chore/fix-upgrade-cli-version-script
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was previously using sed. Which is fine, but sed behaves differently on Linux and macOs. So I wasted a bunch of time trying to understand why it's working locally but not in GitHub Action. Having scripts behave differently in different environments isn't great. So instead of fixing the sed command, this is now using python only.