Skip to content

Commit

Permalink
fix(sqs): fix sqs message age and min incoming dedupe (#540)
Browse files Browse the repository at this point in the history
Our team has a variety of SQS alarms including tiered alarm on message
ages and tiered alarms based on how long we haven't seen messages in.

However, these are not currently deduping as expected which we root
caused to the `alarmDedupeStringSuffix` being missing on these alarms.

The message age issue is reported in #255.

This PR fixes both #255 and the unreported minute incoming messages
issue by adding `alarmDedupeStringSuffix` for them.

Fixes #255

---

_By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache-2.0 license_
  • Loading branch information
rhermes62 authored Jul 2, 2024
1 parent b8f920f commit 8e1f062
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions lib/common/monitoring/alarms/QueueAlarmFactory.ts
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,8 @@ export class QueueAlarmFactory {
threshold: props.maxAgeInSeconds,
alarmNameSuffix: "Queue-Message-Age-Max",
alarmDescription: `Age of the oldest message in the queue is too high.`,
// we will dedupe any kind of message age issue to the same ticket
alarmDedupeStringSuffix: "AnyQueueMessageAge",
});
}

Expand Down Expand Up @@ -136,6 +138,8 @@ export class QueueAlarmFactory {
threshold: props.minIncomingMessagesCount,
alarmNameSuffix: "Queue-Incoming-Messages-Count-Min",
alarmDescription: `Number of incoming messages into the queue is too low.`,
// we will dedupe any kind of min message issues to the same ticket
alarmDedupeStringSuffix: "AnyQueueMinIncomingMessages",
});
}

Expand Down

0 comments on commit 8e1f062

Please sign in to comment.