Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kinesis): change Provisioned Capacity Exceeded metric's Y axis label to CountAxisFromZero #419

Merged
merged 2 commits into from
Aug 31, 2023
Merged

fix(kinesis): change Provisioned Capacity Exceeded metric's Y axis label to CountAxisFromZero #419

merged 2 commits into from
Aug 31, 2023

Conversation

jeremy-zou
Copy link
Contributor

@jeremy-zou jeremy-zou commented Aug 30, 2023 •
edited
Loading

Fixes #418

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@echeung-amzn
Copy link
Member

Thanks for the contribution! This also makes it clear that the naming of metricReadProvisionedThroughputExceededPercent and metricWriteProvisionedThroughputExceededPercent in KinesisDataStreamMetricFactory are incorrect.

Do you mind also:

  1. Creating new methods there (metricReadProvisionedThroughputExceeded and metricWriteProvisionedThroughputExceeded)
  2. Marking the existing methods as deprecated and just calling the new ones
  3. Updating KinesisDataStreamMonitoring to call those new methods

We can remove the old methods later as a breaking change.

@echeung-amzn echeung-amzn changed the title fix: Change Provisioned Capacity Exceeded metric's Y axis label to CountAxisFromZero fix(kinesis): change Provisioned Capacity Exceeded metric's Y axis label to CountAxisFromZero Aug 31, 2023
echeung-amzn
echeung-amzn requested changes Aug 31, 2023
View reviewed changes
Copy link
Member

@echeung-amzn echeung-amzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you're missing the changes to API.md. You should be able to run yarn build to produce the necessary changes.

@jeremy-zou
Copy link
Contributor Author

Looks like you're missing the changes to API.md. You should be able to run yarn build to produce the necessary changes.

Ah yeah I see that. My bad; will fix.

@jeremy-zou
fix: Change Provisioned Capacity Exceeded metric's Y axis props to Co…
cf1e117 
…untAxisFromZero

Deprecates metricReadProvisionedThroughputExceededPercent and
metricWriteProvisionedThroughputExceededPercent methods, as the percent
in the naming is not accurate. The y-axis props for these two metrics
are changed from TimeAxisMillisFromZero (ms) to CountAxisFromZero (Count)
@mergify mergify bot merged commit 4bce103 into cdklabs:main Aug 31, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@echeung-amzn echeung-amzn echeung-amzn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

KinesisDataStreamMonitoring read(andWrite)ProvisionedThroughputExceeded y axis shows up as ms
2 participants
@jeremy-zou @echeung-amzn