fix: make anomaly detection alarm work on math expression #426
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #425
Fixes #340
Changes
Changes to the implementation of
AnomalyDetectionMathExpression
:thresholdMetricId
was assigned the incorrect expression id when multiple math expressions were present in the generated CFN template.returnData
to be true only for theANOMALY_DETECTION_BAND
function and its direct dependency, rather than for all of the metrics inMetrics
.I haven't come across any internal or external documentation indicating that two
returnData: true
are necessary for anomaly detection. However, after doing some experiments on CFN, this appears to be true.Testing
I copied the fix into my own CDK package, with the fix, I was able to deploy my stacks.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license