feat(ecs-patterns): allow imported IBaseService #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }) | ||
| return this.metricFactory.createMetric( | ||
| "CPUUtilization", | ||
| MetricStatistic.AVERAGE, |
There was a problem hiding this comment.
Did the metricFactory used to adapt this metric to Average stats before? If not, then would it be a breaking change in regards to the default stats of this metric?
ayush987goyal
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing logic to get metrics on
BaseServiceis pretty simple and can probably be lifted up toIBaseServiceupstream (similar to the change for load balancers), but I don't have bandwidth to tackle that right now.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license