fix(AlarmFactory): Fix wording for actionsSuppressorExtensionPeriod prop to use 'duration' instead of 'time in seconds' #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rop to use 'duration' instead of 'time in seconds'"
|
Initial build failed since updated |
echeung-amzn
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
No code logic changes.
Unfortunately missed changing
actionsSuppressorExtensionPeriodprop description to use "duration" instead of "time in seconds". The "time in seconds" descriptor is used in CloudFormation documentation, but since the prop type required by CDKCompositeAlarmisDuration, it's more accurate to use "duration" (and to be consistent with the CDK Composite Alarm definition).Note: This wording change was already done for
actionsSuppressorWaitPeriod; onlyactionsSuppressorExtensionPeriodwas missed.Testing
yarn build-- no code logic changes so no additional unit tests necessary.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license