fix(stepfunctions): specify line colors for Step Functions Executions graph to ensure failed executions don't show as green #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamalgill
changed the title
echeung-amzn
requested changes
Aug 20, 2024
There was a problem hiding this comment.
We generally omitted these and left it to CloudWatch defaults so we didn't have to handle a11y concerns too.
The motivation for this is understandable though, but can you at least use (/update) the colors in https://github.com/cdklabs/cdk-monitoring-constructs/blob/main/lib/common/widget/color.ts so they can be consistent across other usages, if any?
|
@echeung-amzn I have pushed a follow-up commit based on your feedback |
echeung-amzn
requested changes
Aug 22, 2024
…ions don't show as green
|
@echeung-amzn I have updated the snaphots via |
echeung-amzn
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Step Functions Executions graph doesn't specify line colors for the various metrics, which may lead to failed executions displaying as a green line, and succeeded executions displaying as an orange line, as in the screenshot below. This PR specifies line colors to avoid that anomaly.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license