fix: PolicyStore field should be mandatory inside PolicyTemplate (#23)

Fixes #22

README.md

@@ -155,6 +155,7 @@ permit (
 );`;
 const template = new PolicyTemplate(scope, 'PolicyTemplate', {
   statement: policyTemplateStatement,
+  policyStore: policyStore,
 });
 
 const policy = new Policy(scope, 'MyTestPolicy', {

src/policy-template.ts

@@ -30,9 +30,9 @@ export interface PolicyTemplateProps {
   /**
    * The policy store that contains the template.
    *
-   * @default - No policy store.
+   * @default - The policy store to attach the new or updated policy template.
    */
-  readonly policyStore?: IPolicyStore;
+  readonly policyStore: IPolicyStore;
 }
 
 export interface PolicyTemplateAttributes {
@@ -65,11 +65,11 @@ export class PolicyTemplate extends PolicyTemplateBase {
   }
 
   /**
-   * Creates a PolicyStore construct that represents an external Policy Store.
+   * Creates a PolicyTemplate construct that represents an external Policy Template.
    *
    * @param scope The parent creating construct (usually `this`).
    * @param id The construct's name.
-   * @param attrs A `PolicyStoreAttributes` object.
+   * @param attrs A `PolicyTemplateAttributes` object.
    */
   public static fromPolicyTemplateAttributes(
     scope: Construct,
@@ -113,15 +113,15 @@ export class PolicyTemplate extends PolicyTemplateBase {
   /**
    * The Policy store that contains the template.
    */
-  readonly policyStore?: IPolicyStore;
+  readonly policyStore: IPolicyStore;
 
   constructor(scope: Construct, id: string, props: PolicyTemplateProps) {
     super(scope, id);
 
     this.policyTemplate = new CfnPolicyTemplate(this, id, {
       statement: props.statement,
       description: props.description,
-      policyStoreId: props.policyStore?.policyStoreId,
+      policyStoreId: props.policyStore.policyStoreId,
     });
     this.policyTemplateId = this.policyTemplate.attrPolicyTemplateId;
     this.statement = this.policyTemplate.statement;

test/policy-template.test.ts

@@ -14,45 +14,31 @@ permit (
 );`;
 
 describe('Policy Template creation', () => {
-  test('Policy Template creation only with Statement', () => {
+  test('Policy Template creation with Statement and PolicyStore', () => {
     // GIVEN
     const stack = new Stack(undefined, 'Stack');
-
-    // WHEN
-    new PolicyTemplate(stack, 'PolicyTemplate', {
-      statement: Statement.fromInline(policyTemplateStatement),
-    });
-
-    // THEN
-    Template.fromStack(stack).hasResourceProperties(
-      'AWS::VerifiedPermissions::PolicyTemplate',
-      {
-        Statement: policyTemplateStatement,
+    const policyStore = new PolicyStore(stack, 'PolicyStore', {
+      validationSettings: {
+        mode: ValidationSettingsMode.OFF,
       },
-    );
-  });
-
-  test('Policy Template creation with Statement and Description', () => {
-    // GIVEN
-    const stack = new Stack(undefined, 'Stack');
+    });
 
     // WHEN
     new PolicyTemplate(stack, 'PolicyTemplate', {
       statement: Statement.fromInline(policyTemplateStatement),
-      description: 'Test Description for Policy Template',
+      policyStore: policyStore,
     });
 
     // THEN
     Template.fromStack(stack).hasResourceProperties(
       'AWS::VerifiedPermissions::PolicyTemplate',
       {
         Statement: policyTemplateStatement,
-        Description: 'Test Description for Policy Template',
       },
     );
   });
 
-  test('Policy Template creation with Statement and Description and PolicyStoreId', () => {
+  test('Policy Template creation with Statement and Description and PolicyStore', () => {
     // GIVEN
     const stack = new Stack(undefined, 'Stack');
     const policyStore = new PolicyStore(stack, 'PolicyStore', {

test/policy.test.ts

@@ -187,6 +187,7 @@ when { true };`;
     });
     const template = new PolicyTemplate(stack, 'PolicyTemplate', {
       statement: Statement.fromInline(policyTemplateStatement),
+      policyStore: policyStore,
     });
 
     // Create a policy and add it to the policy store
@@ -268,6 +269,7 @@ when { true };`;
     });
     const template = new PolicyTemplate(stack, 'PolicyTemplate', {
       statement: Statement.fromInline(policyTemplateStatement),
+      policyStore: policyStore,
     });
 
     // THEN