feat: generate schema from RestApi construct #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reste85
reviewed
Sep 5, 2024
src/policy-store.ts
Outdated
| return buildSchema(namespace, actionNames, groupEntityTypeName); | ||
| } | ||
|
|
||
| private static RELEVANT_HTTP_METHODS = ['get', 'post', 'put', 'patch', 'delete', 'head']; |
There was a problem hiding this comment.
I would not keep it as static, a const should be fine. So we avoid problems with this accessibility.
See similar example: Playground Link
There was a problem hiding this comment.
Just refactored this. Let me know if you had something different in mind. Thanks for the speedy review!
auto-merge was automatically disabled
September 5, 2024 13:55
Head branch was pushed to by a user without write access
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #220
Adds
PolicyStore.schemaFromRestApi(), a method for generating AVP permissions schemas directly from theRestApiconstruct. This alternative allows for easier schema synchronization/generation when API changes occur, complementing the existing PolicyStore.schemaFromOpenApiSpec() that requires a Swagger JSON file.