chore: remove unused Vault Status global secondary index as well as Status property in Vault table

[craigzour]

Summary | Résumé

Part 9 of cds-snc/platform-forms-client#4287

• Removes Status Global Secondary Index on Vault table
• Removes Status property in Vault table

[github-actions]

⚠ Terrform update available

Terraform: 1.10.4 (using 1.9.8)
Terragrunt: 0.72.0 (using 0.69.2)

[github-actions]

Staging: dynamodb

✅   Terraform Init: success
✅   Terraform Validate: success
✅   Terraform Format: success
✅   Terraform Plan: success
✅   Conftest: success

Plan: 0 to add, 1 to change, 0 to destroy

Show summary

CHANGE	NAME
update	aws_dynamodb_table.vault

Show plan

Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # aws_dynamodb_table.vault will be updated in-place
  ~ resource "aws_dynamodb_table" "vault" {
        id                          = "Vault"
        name                        = "Vault"
        tags                        = {}
        # (13 unchanged attributes hidden)

      - attribute {
          - name = "Status" -> null
          - type = "S" -> null
        }

      - global_secondary_index {
          - hash_key           = "FormID" -> null
          - name               = "Status" -> null
          - non_key_attributes = [] -> null
          - projection_type    = "ALL" -> null
          - range_key          = "Status" -> null
          - read_capacity      = 0 -> null
          - write_capacity     = 0 -> null
        }

        # (7 unchanged blocks hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

─────────────────────────────────────────────────────────────────────────────

Saved the plan to: plan.tfplan

To perform exactly these actions, run the following command to apply:
    terraform apply "plan.tfplan"

Show Conftest results

WARN - plan.json - main - Missing Common Tags: ["aws_dynamodb_table.api_audit_logs"]
WARN - plan.json - main - Missing Common Tags: ["aws_dynamodb_table.audit_logs"]
WARN - plan.json - main - Missing Common Tags: ["aws_dynamodb_table.reliability_queue"]
WARN - plan.json - main - Missing Common Tags: ["aws_dynamodb_table.vault"]

23 tests, 19 passed, 4 warnings, 0 failures, 0 exceptions