Add border prop to container component #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Modify actions for staging branch * Rename staging push action
* change alert title from h5 tag to p + strong tag * change pagination border to be more consistent with text and background colour * update version * update version * update version
Update publish github action to use jobs
* Add story for gcds-lang-toggle * Update gcds-pagination rendering + add story
ethanWallace
added a commit
that referenced
this pull request
Jul 19, 2023
* Modify actions for staging branch * Rename staging push action * gcds-lang-toggle + gcds-pagination stories (#180) * Add story for gcds-lang-toggle * Update gcds-pagination rendering + add story * Staging rebase (#185) * GitHub action changes for staging env (#178) * Modify actions for staging branch * Rename staging push action * Renovate base branch update (#179) * V 0.10.3 (#181) * change alert title from h5 tag to p + strong tag * change pagination border to be more consistent with text and background colour * update version * update version * update version * Update publish github action to use sequential jobs (#182) Update publish github action to use jobs * Modify actions for staging branch * gcds-lang-toggle + gcds-pagination stories (#180) * Add story for gcds-lang-toggle * Update gcds-pagination rendering + add story --------- Co-authored-by: Ethan Wallace <[email protected]> * update token path + add missing component tokens (#184) * GitHub action changes for staging env (#178) * Modify actions for staging branch * Rename staging push action * Renovate base branch update (#179) * V 0.10.3 (#181) * change alert title from h5 tag to p + strong tag * change pagination border to be more consistent with text and background colour * update version * update version * update version * Update publish github action to use sequential jobs (#182) Update publish github action to use jobs * Modify actions for staging branch * gcds-lang-toggle + gcds-pagination stories (#180) * Add story for gcds-lang-toggle * Update gcds-pagination rendering + add story * update token path + add missing component tokens * update token package --------- Co-authored-by: Ethan Wallace <[email protected]> * Gcds-card component (#183) * First version of gcds-card * First card styles with slot * Unit test + build files * Card story + rework of whole card link * Add tokens * Update token package * Remove leftover merge conflict syntax * Update property descriptions * Updated card readme * Fix typo * Update token package + add new token * Typo fix * Add CHANGELOG.md to project (#187) * Add CHANGELOG.md * Fix commit rendering * Add unreleased section * V 0.10.4 (#188) * GitHub action changes for staging env (#178) * Modify actions for staging branch * Rename staging push action * Renovate base branch update (#179) * V 0.10.3 (#181) * change alert title from h5 tag to p + strong tag * change pagination border to be more consistent with text and background colour * update version * update version * update version * Update publish github action to use sequential jobs (#182) Update publish github action to use jobs * Modify actions for staging branch * gcds-lang-toggle + gcds-pagination stories (#180) * Add story for gcds-lang-toggle * Update gcds-pagination rendering + add story * gcds-container: add margin + padding prop, rename container prop to size * update tokens * update version --------- Co-authored-by: Ethan Wallace <[email protected]> * Update changelog + update token package (#189) * Add border prop to container component (#191) * GitHub action changes for staging env (#178) * Modify actions for staging branch * Rename staging push action * Renovate base branch update (#179) * V 0.10.3 (#181) * change alert title from h5 tag to p + strong tag * change pagination border to be more consistent with text and background colour * update version * update version * update version * Update publish github action to use sequential jobs (#182) Update publish github action to use jobs * Modify actions for staging branch * gcds-lang-toggle + gcds-pagination stories (#180) * Add story for gcds-lang-toggle * Update gcds-pagination rendering + add story * add border prop to container component * update tokens * update version * update version --------- Co-authored-by: Ethan Wallace <[email protected]> * Update storybook to version 7 (#190) * GitHub action changes for staging env (#178) * Modify actions for staging branch * Rename staging push action * Renovate base branch update (#179) * V 0.10.3 (#181) * change alert title from h5 tag to p + strong tag * change pagination border to be more consistent with text and background colour * update version * update version * update version * Update publish github action to use sequential jobs (#182) Update publish github action to use jobs * Modify actions for staging branch * gcds-lang-toggle + gcds-pagination stories (#180) * Add story for gcds-lang-toggle * Update gcds-pagination rendering + add story * wip: update storybook to version 7.0.0 * wip: update storybook to version 7.0.0 + update story structure * change intro boxes to resources * wip: update stories * wip: update stories * add more stories * improve component preview comments display * fix resources list tags --------- Co-authored-by: Ethan Wallace <[email protected]> * Update storybook version to fix GitHub actions (#194) Update storybook version * Update requiredFileInput validator (#195) * Update required label rendering (#196) * Add properties page for each component in Storybook (#198) * Update changelog (#199) --------- Co-authored-by: Melanie Boeckmann <[email protected]>
ethanWallace
added a commit
that referenced
this pull request
Jul 24, 2023
* Modify actions for staging branch * Rename staging push action * gcds-lang-toggle + gcds-pagination stories (#180) * Add story for gcds-lang-toggle * Update gcds-pagination rendering + add story * Staging rebase (#185) * GitHub action changes for staging env (#178) * Modify actions for staging branch * Rename staging push action * Renovate base branch update (#179) * V 0.10.3 (#181) * change alert title from h5 tag to p + strong tag * change pagination border to be more consistent with text and background colour * update version * update version * update version * Update publish github action to use sequential jobs (#182) Update publish github action to use jobs * Modify actions for staging branch * gcds-lang-toggle + gcds-pagination stories (#180) * Add story for gcds-lang-toggle * Update gcds-pagination rendering + add story --------- Co-authored-by: Ethan Wallace <[email protected]> * update token path + add missing component tokens (#184) * GitHub action changes for staging env (#178) * Modify actions for staging branch * Rename staging push action * Renovate base branch update (#179) * V 0.10.3 (#181) * change alert title from h5 tag to p + strong tag * change pagination border to be more consistent with text and background colour * update version * update version * update version * Update publish github action to use sequential jobs (#182) Update publish github action to use jobs * Modify actions for staging branch * gcds-lang-toggle + gcds-pagination stories (#180) * Add story for gcds-lang-toggle * Update gcds-pagination rendering + add story * update token path + add missing component tokens * update token package --------- Co-authored-by: Ethan Wallace <[email protected]> * Gcds-card component (#183) * First version of gcds-card * First card styles with slot * Unit test + build files * Card story + rework of whole card link * Add tokens * Update token package * Remove leftover merge conflict syntax * Update property descriptions * Updated card readme * Fix typo * Update token package + add new token * Typo fix * Add CHANGELOG.md to project (#187) * Add CHANGELOG.md * Fix commit rendering * Add unreleased section * V 0.10.4 (#188) * GitHub action changes for staging env (#178) * Modify actions for staging branch * Rename staging push action * Renovate base branch update (#179) * V 0.10.3 (#181) * change alert title from h5 tag to p + strong tag * change pagination border to be more consistent with text and background colour * update version * update version * update version * Update publish github action to use sequential jobs (#182) Update publish github action to use jobs * Modify actions for staging branch * gcds-lang-toggle + gcds-pagination stories (#180) * Add story for gcds-lang-toggle * Update gcds-pagination rendering + add story * gcds-container: add margin + padding prop, rename container prop to size * update tokens * update version --------- Co-authored-by: Ethan Wallace <[email protected]> * Update changelog + update token package (#189) * Add border prop to container component (#191) * GitHub action changes for staging env (#178) * Modify actions for staging branch * Rename staging push action * Renovate base branch update (#179) * V 0.10.3 (#181) * change alert title from h5 tag to p + strong tag * change pagination border to be more consistent with text and background colour * update version * update version * update version * Update publish github action to use sequential jobs (#182) Update publish github action to use jobs * Modify actions for staging branch * gcds-lang-toggle + gcds-pagination stories (#180) * Add story for gcds-lang-toggle * Update gcds-pagination rendering + add story * add border prop to container component * update tokens * update version * update version --------- Co-authored-by: Ethan Wallace <[email protected]> * Update storybook to version 7 (#190) * GitHub action changes for staging env (#178) * Modify actions for staging branch * Rename staging push action * Renovate base branch update (#179) * V 0.10.3 (#181) * change alert title from h5 tag to p + strong tag * change pagination border to be more consistent with text and background colour * update version * update version * update version * Update publish github action to use sequential jobs (#182) Update publish github action to use jobs * Modify actions for staging branch * gcds-lang-toggle + gcds-pagination stories (#180) * Add story for gcds-lang-toggle * Update gcds-pagination rendering + add story * wip: update storybook to version 7.0.0 * wip: update storybook to version 7.0.0 + update story structure * change intro boxes to resources * wip: update stories * wip: update stories * add more stories * improve component preview comments display * fix resources list tags --------- Co-authored-by: Ethan Wallace <[email protected]> * Update storybook version to fix GitHub actions (#194) Update storybook version * Update requiredFileInput validator (#195) * Update required label rendering (#196) * Add properties page for each component in Storybook (#198) * Update changelog (#199) * Add new navigation components (#201) * New menu components (#171) * Add first protype versions of new menu components * Basic keyboard control * Keyboard controls for menus * Add mobile menu + slots * Add slotted items to mun item queue * Rename prototype gcds-site-menu * Build + basic tests * Add comments to methods * Update slot position in site-menu * Fix gcds-menu-group appearing as a dependency in all components * Optimize util functions + comments * event key change * Create new toggleMenuGroup function + rename focusElement function * Update slots + unit tests * Gcds menu styling (#186) * wip: add styling for gcds-nav-link component * wip: add styling for gcds-nav-group component * wip: add styling for gcds-side-nav component * wip: add styling for gcds-top-nav component * wip: update index.html and menus/utilss.ts with new nav component names * add mobile styling for all nav components * add mobile styling for all nav components * add nav tokens * Expand keyboard controls to support mobile menu button * Add hidden a11y text to navigation components * Remove open on load from group-nav in top-nav * gcds-nav-group unit tests * nav-link unit tests * top-nav and side-nav unit tests * Add events to gcds-nav-link * Add stories for navigation components * add tablet styling for top- and side-nav (#193) * add tablet styling for top- and side-nav * update nav-group props * change nav-link width * Add new props to nav-group + reformat stories * Comment out position prop for later development * Update comment labels in navigation stories * Update top-nav story for better display --------- Co-authored-by: Melanie Boeckmann <[email protected]> * Reorganize scripts + optimize/fix GitHub actions (#202) * Change scripts location and function * Update actions to only install web component package * Remove mention of workspaces from README * Extra config + checkbox fix (#205) * Add extra config option to help using the web components in some bundlers * Change emitted from value to checked in checkbox * Update form styling (#203) * Modify actions for staging branch * gcds-lang-toggle + gcds-pagination stories (#180) * Add story for gcds-lang-toggle * Update gcds-pagination rendering + add story * update error state styling for form components * add type prop to date modified * remove subheading prop from error summary * add storybook story for date modified * update error summary story and remove subheading * update tokens --------- Co-authored-by: Ethan Wallace <[email protected]> * Update version + changelog (#206) * Update changelog * Update to v0.12.0 --------- Co-authored-by: Melanie Boeckmann <[email protected]>
ethanWallace
added a commit
that referenced
this pull request
Jul 28, 2023
* Modify actions for staging branch * Rename staging push action * gcds-lang-toggle + gcds-pagination stories (#180) * Add story for gcds-lang-toggle * Update gcds-pagination rendering + add story * Staging rebase (#185) * GitHub action changes for staging env (#178) * Modify actions for staging branch * Rename staging push action * Renovate base branch update (#179) * V 0.10.3 (#181) * change alert title from h5 tag to p + strong tag * change pagination border to be more consistent with text and background colour * update version * update version * update version * Update publish github action to use sequential jobs (#182) Update publish github action to use jobs * Modify actions for staging branch * gcds-lang-toggle + gcds-pagination stories (#180) * Add story for gcds-lang-toggle * Update gcds-pagination rendering + add story --------- Co-authored-by: Ethan Wallace <[email protected]> * update token path + add missing component tokens (#184) * GitHub action changes for staging env (#178) * Modify actions for staging branch * Rename staging push action * Renovate base branch update (#179) * V 0.10.3 (#181) * change alert title from h5 tag to p + strong tag * change pagination border to be more consistent with text and background colour * update version * update version * update version * Update publish github action to use sequential jobs (#182) Update publish github action to use jobs * Modify actions for staging branch * gcds-lang-toggle + gcds-pagination stories (#180) * Add story for gcds-lang-toggle * Update gcds-pagination rendering + add story * update token path + add missing component tokens * update token package --------- Co-authored-by: Ethan Wallace <[email protected]> * Gcds-card component (#183) * First version of gcds-card * First card styles with slot * Unit test + build files * Card story + rework of whole card link * Add tokens * Update token package * Remove leftover merge conflict syntax * Update property descriptions * Updated card readme * Fix typo * Update token package + add new token * Typo fix * Add CHANGELOG.md to project (#187) * Add CHANGELOG.md * Fix commit rendering * Add unreleased section * V 0.10.4 (#188) * GitHub action changes for staging env (#178) * Modify actions for staging branch * Rename staging push action * Renovate base branch update (#179) * V 0.10.3 (#181) * change alert title from h5 tag to p + strong tag * change pagination border to be more consistent with text and background colour * update version * update version * update version * Update publish github action to use sequential jobs (#182) Update publish github action to use jobs * Modify actions for staging branch * gcds-lang-toggle + gcds-pagination stories (#180) * Add story for gcds-lang-toggle * Update gcds-pagination rendering + add story * gcds-container: add margin + padding prop, rename container prop to size * update tokens * update version --------- Co-authored-by: Ethan Wallace <[email protected]> * Update changelog + update token package (#189) * Add border prop to container component (#191) * GitHub action changes for staging env (#178) * Modify actions for staging branch * Rename staging push action * Renovate base branch update (#179) * V 0.10.3 (#181) * change alert title from h5 tag to p + strong tag * change pagination border to be more consistent with text and background colour * update version * update version * update version * Update publish github action to use sequential jobs (#182) Update publish github action to use jobs * Modify actions for staging branch * gcds-lang-toggle + gcds-pagination stories (#180) * Add story for gcds-lang-toggle * Update gcds-pagination rendering + add story * add border prop to container component * update tokens * update version * update version --------- Co-authored-by: Ethan Wallace <[email protected]> * Update storybook to version 7 (#190) * GitHub action changes for staging env (#178) * Modify actions for staging branch * Rename staging push action * Renovate base branch update (#179) * V 0.10.3 (#181) * change alert title from h5 tag to p + strong tag * change pagination border to be more consistent with text and background colour * update version * update version * update version * Update publish github action to use sequential jobs (#182) Update publish github action to use jobs * Modify actions for staging branch * gcds-lang-toggle + gcds-pagination stories (#180) * Add story for gcds-lang-toggle * Update gcds-pagination rendering + add story * wip: update storybook to version 7.0.0 * wip: update storybook to version 7.0.0 + update story structure * change intro boxes to resources * wip: update stories * wip: update stories * add more stories * improve component preview comments display * fix resources list tags --------- Co-authored-by: Ethan Wallace <[email protected]> * Update storybook version to fix GitHub actions (#194) Update storybook version * Update requiredFileInput validator (#195) * Update required label rendering (#196) * Add properties page for each component in Storybook (#198) * Update changelog (#199) * Add new navigation components (#201) * New menu components (#171) * Add first protype versions of new menu components * Basic keyboard control * Keyboard controls for menus * Add mobile menu + slots * Add slotted items to mun item queue * Rename prototype gcds-site-menu * Build + basic tests * Add comments to methods * Update slot position in site-menu * Fix gcds-menu-group appearing as a dependency in all components * Optimize util functions + comments * event key change * Create new toggleMenuGroup function + rename focusElement function * Update slots + unit tests * Gcds menu styling (#186) * wip: add styling for gcds-nav-link component * wip: add styling for gcds-nav-group component * wip: add styling for gcds-side-nav component * wip: add styling for gcds-top-nav component * wip: update index.html and menus/utilss.ts with new nav component names * add mobile styling for all nav components * add mobile styling for all nav components * add nav tokens * Expand keyboard controls to support mobile menu button * Add hidden a11y text to navigation components * Remove open on load from group-nav in top-nav * gcds-nav-group unit tests * nav-link unit tests * top-nav and side-nav unit tests * Add events to gcds-nav-link * Add stories for navigation components * add tablet styling for top- and side-nav (#193) * add tablet styling for top- and side-nav * update nav-group props * change nav-link width * Add new props to nav-group + reformat stories * Comment out position prop for later development * Update comment labels in navigation stories * Update top-nav story for better display --------- Co-authored-by: Melanie Boeckmann <[email protected]> * Reorganize scripts + optimize/fix GitHub actions (#202) * Change scripts location and function * Update actions to only install web component package * Remove mention of workspaces from README * Extra config + checkbox fix (#205) * Add extra config option to help using the web components in some bundlers * Change emitted from value to checked in checkbox * Update form styling (#203) * Modify actions for staging branch * gcds-lang-toggle + gcds-pagination stories (#180) * Add story for gcds-lang-toggle * Update gcds-pagination rendering + add story * update error state styling for form components * add type prop to date modified * remove subheading prop from error summary * add storybook story for date modified * update error summary story and remove subheading * update tokens --------- Co-authored-by: Ethan Wallace <[email protected]> * Update version + changelog (#206) * Update changelog * Update to v0.12.0 * Fix compile-and-publish action angular publishing (#209) Add install repo back into instructions for angular package * A11y fixes (#208) * Voice control a11y fix for file uploader * Change focus management in nav components for better usability * Update for v0.12.1 release (#210) * Update changelog * v0.12.1 version update * Basic search component * Remove search --------- Co-authored-by: Melanie Boeckmann <[email protected]>
ethanWallace
added a commit
that referenced
this pull request
Aug 15, 2023
* Modify actions for staging branch * Rename staging push action * gcds-lang-toggle + gcds-pagination stories (#180) * Add story for gcds-lang-toggle * Update gcds-pagination rendering + add story * Staging rebase (#185) * GitHub action changes for staging env (#178) * Modify actions for staging branch * Rename staging push action * Renovate base branch update (#179) * V 0.10.3 (#181) * change alert title from h5 tag to p + strong tag * change pagination border to be more consistent with text and background colour * update version * update version * update version * Update publish github action to use sequential jobs (#182) Update publish github action to use jobs * Modify actions for staging branch * gcds-lang-toggle + gcds-pagination stories (#180) * Add story for gcds-lang-toggle * Update gcds-pagination rendering + add story --------- Co-authored-by: Ethan Wallace <[email protected]> * update token path + add missing component tokens (#184) * GitHub action changes for staging env (#178) * Modify actions for staging branch * Rename staging push action * Renovate base branch update (#179) * V 0.10.3 (#181) * change alert title from h5 tag to p + strong tag * change pagination border to be more consistent with text and background colour * update version * update version * update version * Update publish github action to use sequential jobs (#182) Update publish github action to use jobs * Modify actions for staging branch * gcds-lang-toggle + gcds-pagination stories (#180) * Add story for gcds-lang-toggle * Update gcds-pagination rendering + add story * update token path + add missing component tokens * update token package --------- Co-authored-by: Ethan Wallace <[email protected]> * Gcds-card component (#183) * First version of gcds-card * First card styles with slot * Unit test + build files * Card story + rework of whole card link * Add tokens * Update token package * Remove leftover merge conflict syntax * Update property descriptions * Updated card readme * Fix typo * Update token package + add new token * Typo fix * Add CHANGELOG.md to project (#187) * Add CHANGELOG.md * Fix commit rendering * Add unreleased section * V 0.10.4 (#188) * GitHub action changes for staging env (#178) * Modify actions for staging branch * Rename staging push action * Renovate base branch update (#179) * V 0.10.3 (#181) * change alert title from h5 tag to p + strong tag * change pagination border to be more consistent with text and background colour * update version * update version * update version * Update publish github action to use sequential jobs (#182) Update publish github action to use jobs * Modify actions for staging branch * gcds-lang-toggle + gcds-pagination stories (#180) * Add story for gcds-lang-toggle * Update gcds-pagination rendering + add story * gcds-container: add margin + padding prop, rename container prop to size * update tokens * update version --------- Co-authored-by: Ethan Wallace <[email protected]> * Update changelog + update token package (#189) * Add border prop to container component (#191) * GitHub action changes for staging env (#178) * Modify actions for staging branch * Rename staging push action * Renovate base branch update (#179) * V 0.10.3 (#181) * change alert title from h5 tag to p + strong tag * change pagination border to be more consistent with text and background colour * update version * update version * update version * Update publish github action to use sequential jobs (#182) Update publish github action to use jobs * Modify actions for staging branch * gcds-lang-toggle + gcds-pagination stories (#180) * Add story for gcds-lang-toggle * Update gcds-pagination rendering + add story * add border prop to container component * update tokens * update version * update version --------- Co-authored-by: Ethan Wallace <[email protected]> * Update storybook to version 7 (#190) * GitHub action changes for staging env (#178) * Modify actions for staging branch * Rename staging push action * Renovate base branch update (#179) * V 0.10.3 (#181) * change alert title from h5 tag to p + strong tag * change pagination border to be more consistent with text and background colour * update version * update version * update version * Update publish github action to use sequential jobs (#182) Update publish github action to use jobs * Modify actions for staging branch * gcds-lang-toggle + gcds-pagination stories (#180) * Add story for gcds-lang-toggle * Update gcds-pagination rendering + add story * wip: update storybook to version 7.0.0 * wip: update storybook to version 7.0.0 + update story structure * change intro boxes to resources * wip: update stories * wip: update stories * add more stories * improve component preview comments display * fix resources list tags --------- Co-authored-by: Ethan Wallace <[email protected]> * Update storybook version to fix GitHub actions (#194) Update storybook version * Update requiredFileInput validator (#195) * Update required label rendering (#196) * Add properties page for each component in Storybook (#198) * Update changelog (#199) * Add new navigation components (#201) * New menu components (#171) * Add first protype versions of new menu components * Basic keyboard control * Keyboard controls for menus * Add mobile menu + slots * Add slotted items to mun item queue * Rename prototype gcds-site-menu * Build + basic tests * Add comments to methods * Update slot position in site-menu * Fix gcds-menu-group appearing as a dependency in all components * Optimize util functions + comments * event key change * Create new toggleMenuGroup function + rename focusElement function * Update slots + unit tests * Gcds menu styling (#186) * wip: add styling for gcds-nav-link component * wip: add styling for gcds-nav-group component * wip: add styling for gcds-side-nav component * wip: add styling for gcds-top-nav component * wip: update index.html and menus/utilss.ts with new nav component names * add mobile styling for all nav components * add mobile styling for all nav components * add nav tokens * Expand keyboard controls to support mobile menu button * Add hidden a11y text to navigation components * Remove open on load from group-nav in top-nav * gcds-nav-group unit tests * nav-link unit tests * top-nav and side-nav unit tests * Add events to gcds-nav-link * Add stories for navigation components * add tablet styling for top- and side-nav (#193) * add tablet styling for top- and side-nav * update nav-group props * change nav-link width * Add new props to nav-group + reformat stories * Comment out position prop for later development * Update comment labels in navigation stories * Update top-nav story for better display --------- Co-authored-by: Melanie Boeckmann <[email protected]> * Reorganize scripts + optimize/fix GitHub actions (#202) * Change scripts location and function * Update actions to only install web component package * Remove mention of workspaces from README * Extra config + checkbox fix (#205) * Add extra config option to help using the web components in some bundlers * Change emitted from value to checked in checkbox * Update form styling (#203) * Modify actions for staging branch * gcds-lang-toggle + gcds-pagination stories (#180) * Add story for gcds-lang-toggle * Update gcds-pagination rendering + add story * update error state styling for form components * add type prop to date modified * remove subheading prop from error summary * add storybook story for date modified * update error summary story and remove subheading * update tokens --------- Co-authored-by: Ethan Wallace <[email protected]> * Update version + changelog (#206) * Update changelog * Update to v0.12.0 * Fix compile-and-publish action angular publishing (#209) Add install repo back into instructions for angular package * A11y fixes (#208) * Voice control a11y fix for file uploader * Change focus management in nav components for better usability * Update for v0.12.1 release (#210) * Update changelog * v0.12.1 version update * Basic search component * Remove search --------- Co-authored-by: Melanie Boeckmann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Depending on #134