Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update available options in select if changed #655

Merged
merged 1 commit into from
Oct 3, 2024
Merged

fix: Update available options in select if changed #655

merged 1 commit into from
Oct 3, 2024

Conversation

ethanWallace
Copy link
Collaborator

@ethanWallace ethanWallace commented Oct 2, 2024 •
edited
Loading

Summary | Résumé

Add mutationObserver to gcds-select to observe if passed <options> have been changed. This allows the select component to keep the same behaviour as the HTML select.

Example of issue using React

#643

melaniebmn
melaniebmn approved these changes Oct 2, 2024
View reviewed changes
Copy link
Collaborator

@melaniebmn melaniebmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ethanWallace ethanWallace merged commit e7a16cb into main Oct 3, 2024
3 checks passed
@ethanWallace ethanWallace deleted the fix/update-select-options branch October 3, 2024 12:36
@sre-read-write sre-read-write bot mentioned this pull request Oct 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melaniebmn melaniebmn melaniebmn approved these changes

@daine daine Awaiting requested review from daine

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ethanWallace @melaniebmn