Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V 1.5.4 #144

Merged
merged 3 commits into from
Aug 16, 2023
Merged

V 1.5.4 #144

merged 3 commits into from
Aug 16, 2023

Conversation

nmakuch
Copy link
Contributor

@nmakuch nmakuch commented Aug 15, 2023

Token update based on figma/repo comparitive review

@nmakuch nmakuch mentioned this pull request Aug 15, 2023
Merged
melaniebmn
melaniebmn requested changes Aug 16, 2023
View reviewed changes
Copy link
Collaborator

@melaniebmn melaniebmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few comments to replace hardcoded values with global tokens but other than that, it looks good.

melaniebmn
melaniebmn approved these changes Aug 16, 2023
View reviewed changes
Copy link
Collaborator

@melaniebmn melaniebmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nmakuch nmakuch merged commit c25f397 into main Aug 16, 2023
1 check passed
@nmakuch nmakuch deleted the token-review-updates branch August 16, 2023 20:32
@melaniebmn melaniebmn changed the title token update for changes from token review V 1.5.4 Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melaniebmn melaniebmn melaniebmn approved these changes

@ethanWallace ethanWallace Awaiting requested review from ethanWallace

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nmakuch @melaniebmn