Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: "feat: Update notice tokens for new icon design" #331

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

ethanWallace
Copy link
Collaborator

@ethanWallace ethanWallace commented Oct 2, 2024

Reverts #330

Reverting PR to resubmit changes with proper commit title to trigger release-please properly

@daine
Copy link
Collaborator

daine commented Oct 2, 2024

If we were doing reverts on previous conventional commits we can also do revert: and then reference the refs in the footer https://www.conventionalcommits.org/en/v1.0.0/#how-does-conventional-commits-handle-revert-commits

But, release please didn't pick up the commit we're reverting so it's best it also doesn't pick up this commit

@ethanWallace ethanWallace changed the title Revert "feat: Update notice tokens for new icon design" revert: "feat: Update notice tokens for new icon design" Oct 2, 2024
@ethanWallace ethanWallace merged commit f93591f into main Oct 2, 2024
1 check passed
@ethanWallace ethanWallace deleted the revert-330-feat/update-notice-tokens branch October 2, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants