Skip to content

Commit

Permalink
Revert "Adding alarms for github arc runner failures (#1242)"
Browse files Browse the repository at this point in the history
This reverts commit 5cec317.
  • Loading branch information
ben851 authored May 13, 2024
1 parent 5cec317 commit 487709e
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 29 deletions.
16 changes: 0 additions & 16 deletions aws/eks/cloudwatch_alarms.tf
Original file line number Diff line number Diff line change
Expand Up @@ -938,19 +938,3 @@ resource "aws_cloudwatch_metric_alarm" "aggregating-queues-not-active-5-minutes-
alarm_actions = [var.sns_alert_critical_arn]
ok_actions = [var.sns_alert_critical_arn]
}

resource "aws_cloudwatch_metric_alarm" "github-arc-runner-write-alarm" {
count = var.cloudwatch_enabled ? 1 : 0
alarm_name = "github-arc-runner-write-alarm"
alarm_description = "GitHub ARC Runners Are Failing - Check Version Deprecation"
comparison_operator = "LessThanThreshold"
evaluation_periods = "1"
metric_name = aws_cloudwatch_log_metric_filter.github-arc-write-alarm[0].metric_transformation[0].name
namespace = aws_cloudwatch_log_metric_filter.github-arc-write-alarm[0].metric_transformation[0].namespace
period = "300"
statistic = "Sum"
threshold = 1
treat_missing_data = "notBreaching"
alarm_actions = [var.sns_alert_critical_arn]
ok_actions = [var.sns_alert_critical_arn]
}
13 changes: 0 additions & 13 deletions aws/eks/cloudwatch_log.tf
Original file line number Diff line number Diff line change
Expand Up @@ -166,16 +166,3 @@ resource "aws_cloudwatch_log_metric_filter" "aggregating-queues-are-active" {
value = "1"
}
}

resource "aws_cloudwatch_log_metric_filter" "github-arc-write-alarm" {
count = var.cloudwatch_enabled ? 1 : 0
name = "GitHub ARC Runners Write Alarm"
pattern = "WRITE ERROR: An error occured:"
log_group_name = aws_cloudwatch_log_group.notification-canada-ca-eks-application-logs[0].name

metric_transformation {
name = "aggregating-github-arc-write-alarm"
namespace = "LogMetrics"
value = "1"
}
}

0 comments on commit 487709e

Please sign in to comment.